Bug 43638 - sort-Xcode-project-file with warnings and strange behavior
Summary: sort-Xcode-project-file with warnings and strange behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 13:22 PDT by Dirk Schulze
Modified: 2010-08-09 09:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.87 KB, patch)
2010-08-09 04:27 PDT, Marcus Bulach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2010-08-06 13:22:41 PDT
sort-Xcode-project-file have given warning since three days:

Use of uninitialized value $aFileName in pattern match (m//) at WebKitTools/Scripts/sort-Xcode-project-file line 153, <IN> line 11573.
Use of uninitialized value $aFileName in hash element at WebKitTools/Scripts/sort-Xcode-project-file line 155, <IN> line 11573.

Some sorting results look a bit strange sometimes like this one:

-				81BE209211F4AB8D00915DFA /* IDBCursor.cpp */,
+				81BE209211F4AB8D00915DFA /* IDBCursor.h */,
 				81BE209211F4AB8D00915DFA /* IDBCursor.h */,

Every appearance of IDBCursor.cpp got deleted. And like you can see in the example above,  IDBCursor.h was added twice.
Comment 1 Nikolas Zimmermann 2010-08-06 22:28:20 PDT
I think r64828, is guilty, ccing Marcus Bulach.

There are duplicated IDs in the Xcode file, the IDB stuff can not build on WebKit at the moment, and it breaks our sort-Xcode-project-file script.

Marcus, can you please fix the broken Xcode file?
Comment 2 Marcus Bulach 2010-08-09 02:22:55 PDT
(In reply to comment #1)
> I think r64828, is guilty, ccing Marcus Bulach.
> 
> There are duplicated IDs in the Xcode file, the IDB stuff can not build on WebKit at the moment, and it breaks our sort-Xcode-project-file script.
> 
> Marcus, can you please fix the broken Xcode file?

sorry about this, looking at it now, will upload a patch shortly.
Comment 3 Marcus Bulach 2010-08-09 04:27:48 PDT
Created attachment 63883 [details]
Patch
Comment 4 Marcus Bulach 2010-08-09 04:30:59 PDT
Comment on attachment 63883 [details]
Patch

Hi Dirk, Nikolas,

I re-added the files and ran sort-Xcode-project-file again, hopefully it should be fine now. Apologies once again.

Would you mind taking a look at the patch please? Thanks!
Comment 5 Darin Adler 2010-08-09 09:27:23 PDT
Comment on attachment 63883 [details]
Patch

I do not understand the title of this bug. It does not describe a problem, nor can I figure out what it's saying. "<name-of-script> with warnings and strange behavior"? Huh?

The patch looks fine.
Comment 6 Eric Seidel (no email) 2010-08-09 09:39:49 PDT
Comment on attachment 63883 [details]
Patch

Clearing flags on attachment: 63883

Committed r64987: <http://trac.webkit.org/changeset/64987>
Comment 7 Eric Seidel (no email) 2010-08-09 09:39:55 PDT
All reviewed patches have been landed.  Closing bug.