RESOLVED FIXED 43638
sort-Xcode-project-file with warnings and strange behavior 
https://bugs.webkit.org/show_bug.cgi?id=43638
Summary sort-Xcode-project-file with warnings and strange behavior
Dirk Schulze
Reported 2010-08-06 13:22:41 PDT
sort-Xcode-project-file have given warning since three days: Use of uninitialized value $aFileName in pattern match (m//) at WebKitTools/Scripts/sort-Xcode-project-file line 153, <IN> line 11573. Use of uninitialized value $aFileName in hash element at WebKitTools/Scripts/sort-Xcode-project-file line 155, <IN> line 11573. Some sorting results look a bit strange sometimes like this one: - 81BE209211F4AB8D00915DFA /* IDBCursor.cpp */, + 81BE209211F4AB8D00915DFA /* IDBCursor.h */, 81BE209211F4AB8D00915DFA /* IDBCursor.h */, Every appearance of IDBCursor.cpp got deleted. And like you can see in the example above, IDBCursor.h was added twice.
Attachments
Patch (7.87 KB, patch)
2010-08-09 04:27 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-08-06 22:28:20 PDT
I think r64828, is guilty, ccing Marcus Bulach. There are duplicated IDs in the Xcode file, the IDB stuff can not build on WebKit at the moment, and it breaks our sort-Xcode-project-file script. Marcus, can you please fix the broken Xcode file?
Marcus Bulach
Comment 2 2010-08-09 02:22:55 PDT
(In reply to comment #1) > I think r64828, is guilty, ccing Marcus Bulach. > > There are duplicated IDs in the Xcode file, the IDB stuff can not build on WebKit at the moment, and it breaks our sort-Xcode-project-file script. > > Marcus, can you please fix the broken Xcode file? sorry about this, looking at it now, will upload a patch shortly.
Marcus Bulach
Comment 3 2010-08-09 04:27:48 PDT
Created attachment 63883 [details] Patch
Marcus Bulach
Comment 4 2010-08-09 04:30:59 PDT
Comment on attachment 63883 [details] Patch Hi Dirk, Nikolas, I re-added the files and ran sort-Xcode-project-file again, hopefully it should be fine now. Apologies once again. Would you mind taking a look at the patch please? Thanks!
Darin Adler
Comment 5 2010-08-09 09:27:23 PDT
Comment on attachment 63883 [details] Patch I do not understand the title of this bug. It does not describe a problem, nor can I figure out what it's saying. "<name-of-script> with warnings and strange behavior"? Huh? The patch looks fine.
Eric Seidel (no email)
Comment 6 2010-08-09 09:39:49 PDT
Comment on attachment 63883 [details] Patch Clearing flags on attachment: 63883 Committed r64987: <http://trac.webkit.org/changeset/64987>
Eric Seidel (no email)
Comment 7 2010-08-09 09:39:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.