Bug 43633 - Factor an AsyncScriptRunner out of Document
Summary: Factor an AsyncScriptRunner out of Document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 20710
  Show dependency tree / graph
 
Reported: 2010-08-06 11:58 PDT by Tony Gentilcore
Modified: 2010-08-06 15:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (21.03 KB, patch)
2010-08-06 12:05 PDT, Tony Gentilcore 		eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-08-06 11:58:21 PDT 
Factor an AsyncScriptRunner out of Document
Comment 1 Tony Gentilcore 2010-08-06 12:05:14 PDT 
Created attachment 63749 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-06 12:06:45 PDT 
Attachment 63749 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/dom/Document.h:51:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-08-06 12:08:46 PDT 
Comment on attachment 63749 [details]
Patch

LGTM.
Comment 4 Tony Gentilcore 2010-08-06 12:09:11 PDT 
> WebCore/dom/Document.h:51:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
This is unavoidable. I added a forward decl in Document.h which is already indented.
Comment 5 Adam Barth 2010-08-06 14:35:45 PDT 
> This is unavoidable. I added a forward decl in Document.h which is already indented.

At some point we should bit the bullet and reformat this header.
Comment 6 Tony Gentilcore 2010-08-06 14:38:32 PDT 
> At some point we should bit the bullet and reformat this header.

After this lands I'll put together a patch to fix all the style violations in Document.h.
Comment 7 Tony Gentilcore 2010-08-06 15:10:51 PDT 
Committed r64873: <http://trac.webkit.org/changeset/64873>