Bug 43631 - add "const" to WebChromeClient::webView().
Summary: add "const" to WebChromeClient::webView().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 11:19 PDT by Yongjun Zhang
Modified: 2010-08-06 14:23 PDT (History)
2 users (show)

See Also:


Attachments
Change WebChromeClient::webView() to be const. (1.33 KB, patch)
2010-08-06 11:28 PDT, Yongjun Zhang
eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2010-08-06 11:19:21 PDT
ChromeClient::didReceiveViewportArguments() has changed to be a "const" method.   If we call WebChromeClient::webView() inside port-specific didReceiveViewportArguments() const, the compiler won't be happy because currently webView() is not const.  We need to change WebChromeClient()::webView() to be "const".
Comment 1 Yongjun Zhang 2010-08-06 11:20:04 PDT
It is blocking <rdar://problem/8274174>.
Comment 2 Yongjun Zhang 2010-08-06 11:28:10 PDT
Created attachment 63744 [details]
Change WebChromeClient::webView() to be const.
Comment 3 Eric Seidel (no email) 2010-08-06 13:15:44 PDT
Comment on attachment 63744 [details]
Change WebChromeClient::webView() to be const.

OK.
Comment 4 Joseph Pecoraro 2010-08-06 14:23:38 PDT
Committed r64868
	M	WebKit/mac/WebCoreSupport/WebChromeClient.h
	M	WebKit/mac/ChangeLog
r64868 = aa39e0ac7d3f2dd39f182bef3818b79e35d8db2e (refs/remotes/trunk)
http://trac.webkit.org/changeset/64868