A separated build step for WebKit2 would help us keeping the build environment clean and effective. If WebKit2 would has it's own build step then we could handle the WebKit2Prefix.h file as a prefix header so we could avoid using precompiled header that brakes distcc. The other positive effect would be that identical file names in WebCore and WebKit2 would not cause a problem (currently the build is broken because we have a PluginView.cpp in WebKit2 and in WebCore as well).
Created attachment 63724 [details] proposed patch
Comment on attachment 63724 [details] proposed patch rs=me.
Comment on attachment 63724 [details] proposed patch Clearing flags on attachment: 63724 Committed r64904: <http://trac.webkit.org/changeset/64904>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/64904 might have broken Qt Windows 32-bit Release
(In reply to comment #5) > http://trac.webkit.org/changeset/64904 might have broken Qt Windows 32-bit Release I'm investigating this issue.
Had to rollout because of Qt Windows build breakage.
Created attachment 63819 [details] fixed patch In the previous patch a portion from WebKit.pri was not moved to features.pri. I believe that this was the reason of the build breakage.
Reopen, because the previous patch was rolled out.
Comment on attachment 63819 [details] fixed patch r=me, given that simon already reviewed it and you fixed the win build regressin.
Comment on attachment 63819 [details] fixed patch Clearing flags on attachment: 63819 Committed r65070: <http://trac.webkit.org/changeset/65070>
Comment on attachment 63819 [details] fixed patch Rejecting patch 63819 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 63819, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: .org/attachment.cgi?id=63819&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=43621&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 63819 from bug 43621. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
http://trac.webkit.org/changeset/65070 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/65072 http://trac.webkit.org/changeset/65069 http://trac.webkit.org/changeset/65070 http://trac.webkit.org/changeset/65071
This breaks the build on macos as mac does not understand -whole-archive. message: ld: unknown option: -whole-archive collect2: ld returned 1 exit status
(In reply to comment #15) > This breaks the build on macos as mac does not understand -whole-archive. > > message: > > ld: unknown option: -whole-archive > collect2: ld returned 1 exit status There should be an equivalent on mac. I know nothing about mac, so you should find somebody with the appropriate knowledge. I would like to track the issue in a separate bug.
(In reply to comment #16) > (In reply to comment #15) > > This breaks the build on macos as mac does not understand -whole-archive. > > > > message: > > > > ld: unknown option: -whole-archive > > collect2: ld returned 1 exit status > > There should be an equivalent on mac. I know nothing about mac, so you should find somebody with the appropriate knowledge. I would like to track the issue in a separate bug. Apple's libtool accepts the -all_load option, which should be equivalent to -whole-archive. There should be a conditional check in the project file. IIRC Antti and Simon tried something in the past, I thought the fix already landed, seems it didn't.
(In reply to comment #16) > (In reply to comment #15) > > This breaks the build on macos as mac does not understand -whole-archive. > > > > message: > > > > ld: unknown option: -whole-archive > > collect2: ld returned 1 exit status > > There should be an equivalent on mac. I know nothing about mac, so you should find somebody with the appropriate knowledge. I would like to track the issue in a separate bug. ok. fixed in bug 47167.