Bug 43620 - NPAPI headers should be included through npruntime_internal.h
Summary: NPAPI headers should be included through npruntime_internal.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-08-06 07:11 PDT by Balazs Kelemen
Modified: 2010-08-07 06:51 PDT (History)
6 users (show)

See Also:

proposed patch (2.44 KB, patch)
2010-08-06 07:19 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-08-06 07:11:20 PDT
npruntime_internal.h says "If you need to include npapi.h or npruntime.h when building on X11, include this file instead of the actual npapi.h or npruntime.h." Currently in the WebKit2 directory there are files that includes npapi.h and npruntime.h directly. This brakes the build of the qt port. I would suggest to observe the rule everywhere.
Comment 1 Balazs Kelemen 2010-08-06 07:19:03 PDT
Created attachment 63720 [details]
proposed patch

Change includes in WebKit2
Comment 2 Eric Seidel (no email) 2010-08-06 14:44:39 PDT
Looks non-harmful.
Comment 3 Andras Becsi 2010-08-07 04:48:14 PDT
Committed r64905: <http://trac.webkit.org/changeset/64905>
Comment 4 WebKit Review Bot 2010-08-07 06:20:05 PDT
http://trac.webkit.org/changeset/64905 might have broken Leopard Intel Debug (Tests)
Comment 5 Balazs Kelemen 2010-08-07 06:51:03 PDT
Comment on attachment 63720 [details]
proposed patch

Clearing flags on committed patch.