RESOLVED FIXED Bug 43606
dump-as-markup should work in Firefox 
https://bugs.webkit.org/show_bug.cgi?id=43606
Summary dump-as-markup should work in Firefox
Adam Barth
Reported 2010-08-05 21:00:45 PDT
dump-as-markup should work in Firefox
Attachments
Patch (3.42 KB, patch)
2010-08-05 21:01 PDT, Adam Barth 		ojan: review+
ojan: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-05 21:01:41 PDT
Created attachment 63687 [details] Patch
Eric Seidel (no email)
Comment 2 2010-08-06 13:17:43 PDT
Seems ojan is your man here.
Ojan Vafai
Comment 3 2010-08-06 13:22:17 PDT
Comment on attachment 63687 [details] Patch > +++ b/LayoutTests/ChangeLog > + Apparently Firefox lacks this API. I think something else is going wrong here. document.body.ownerDocument.defaultView.getSelection() returns a selection object in Firefox. Does this fail for all dump-as-markup tests? Does it throw an exception?
Adam Barth
Comment 4 2010-08-06 14:34:32 PDT
I ran into the problem trying to run runner.html in Firefox. That dumps all kinds of crazy DOMs.
Ojan Vafai
Comment 5 2010-08-06 17:18:08 PDT
Comment on attachment 63687 [details] Patch You learn something new everyday. :) Filed https://bugs.webkit.org/show_bug.cgi?id=43655 for the difference in behavior. Mind just adding a comment to _getSelectionFromNode about the case where it returns null? i.e. when the selection is inside a display:none iframe in Firefox.
Adam Barth
Comment 6 2010-08-06 20:30:39 PDT
Committed r64892: <http://trac.webkit.org/changeset/64892>
Note You need to log in before you can comment on or make changes to this bug.