RESOLVED INVALID 43604
AX: Remove some dead code from AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=43604
Summary AX: Remove some dead code from AccessibilityRenderObject
Chris Guillory
Reported 2010-08-05 20:14:38 PDT
Change to remove dead code from AccessibilityRenderObject.
Attachments
Remove dead code from AccessibilityRenderObject (2.56 KB, patch)
2010-08-05 20:18 PDT, Chris Guillory
no flags
Chris Guillory
Comment 1 2010-08-05 20:18:47 PDT
Created attachment 63683 [details] Remove dead code from AccessibilityRenderObject
chris fleizach
Comment 2 2010-08-05 21:15:15 PDT
i don't think this is dead code. this would be used by role="range" if i'm not mistaken
Chris Guillory
Comment 3 2010-08-06 09:41:47 PDT
Which object has the range role? The win bot succeeded.
chris fleizach
Comment 4 2010-08-06 09:42:36 PDT
you can set an element to a range <div role="range"></div>
Chris Guillory
Comment 5 2010-08-06 11:40:22 PDT
Looks like AccessibilityObjectWrapper.mm is using these functions. Too bad the mac bot doesn't run for non-committers.
Eric Seidel (no email)
Comment 6 2010-08-06 13:21:01 PDT
Comment on attachment 63683 [details] Remove dead code from AccessibilityRenderObject We should remove any non-tested code. :p If this is in use, could one of your chrises add a test?
chris fleizach
Comment 7 2010-08-06 13:40:46 PDT
(In reply to comment #6) > (From update of attachment 63683 [details]) > We should remove any non-tested code. :p > > If this is in use, could one of your chrises add a test? LayoutTests/platform/mac/accessibility/aria-range.html LayoutTests/platform/mac/accessibility/aria-range-value.html
chris fleizach
Comment 8 2010-08-06 13:41:05 PDT
(In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 63683 [details] [details]) > > We should remove any non-tested code. :p > > > > If this is in use, could one of your chrises add a test? > > LayoutTests/platform/mac/accessibility/aria-range.html > LayoutTests/platform/mac/accessibility/aria-range-value.html also meant to say, "already exists"
Note You need to log in before you can comment on or make changes to this bug.