RESOLVED FIXED 43603
Add form client for injected bundle code 
https://bugs.webkit.org/show_bug.cgi?id=43603
Summary Add form client for injected bundle code
Sam Weinig
Reported 2010-08-05 19:37:51 PDT
Add form client for injected bundle code.
Attachments
Patch (8.29 KB, patch)
2010-08-05 20:06 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Updated patch (21.91 KB, patch)
2010-08-05 20:53 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-08-05 20:06:35 PDT
Created attachment 63682 [details] Patch
WebKit Review Bot
Comment 2 2010-08-05 20:10:13 PDT
Attachment 63682 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:131: Extra space between int and version [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:133: Extra space between WKBundlePageTextFieldDidBeginEditingCallback and textFieldDidBeginEditing [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:134: Extra space between WKBundlePageTextFieldDidEndEditingCallback and textFieldDidEndEditing [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:135: Extra space between WKBundlePageTextDidChangeInTextFieldCallback and textDidChangeInTextField [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:136: Extra space between WKBundlePageTextDidChangeInTextAreaCallback and textDidChangeInTextArea [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-08-05 20:53:57 PDT
Created attachment 63685 [details] Updated patch Oops, wrong patch uploaded.
WebKit Review Bot
Comment 4 2010-08-05 20:57:56 PDT
Attachment 63685 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:131: Extra space between int and version [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:133: Extra space between WKBundlePageTextFieldDidBeginEditingCallback and textFieldDidBeginEditing [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:134: Extra space between WKBundlePageTextFieldDidEndEditingCallback and textFieldDidEndEditing [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:135: Extra space between WKBundlePageTextDidChangeInTextFieldCallback and textDidChangeInTextField [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:136: Extra space between WKBundlePageTextDidChangeInTextAreaCallback and textDidChangeInTextArea [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 7 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5 2010-08-06 11:54:31 PDT
Landed in r64862.
Note You need to log in before you can comment on or make changes to this bug.