Bug 43603 - Add form client for injected bundle code
Summary: Add form client for injected bundle code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 19:37 PDT by Sam Weinig
Modified: 2010-08-06 11:54 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.29 KB, patch)
2010-08-05 20:06 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Updated patch (21.91 KB, patch)
2010-08-05 20:53 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-08-05 19:37:51 PDT 
Add form client for injected bundle code.
Comment 1 Sam Weinig 2010-08-05 20:06:35 PDT 
Created attachment 63682 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-05 20:10:13 PDT 
Attachment 63682 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:131:  Extra space between int and version  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:133:  Extra space between WKBundlePageTextFieldDidBeginEditingCallback and textFieldDidBeginEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:134:  Extra space between WKBundlePageTextFieldDidEndEditingCallback and textFieldDidEndEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:135:  Extra space between WKBundlePageTextDidChangeInTextFieldCallback and textDidChangeInTextField  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:136:  Extra space between WKBundlePageTextDidChangeInTextAreaCallback and textDidChangeInTextArea  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-08-05 20:53:57 PDT 
Created attachment 63685 [details]
Updated patch

Oops, wrong patch uploaded.
Comment 4 WebKit Review Bot 2010-08-05 20:57:56 PDT 
Attachment 63685 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:131:  Extra space between int and version  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:133:  Extra space between WKBundlePageTextFieldDidBeginEditingCallback and textFieldDidBeginEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:134:  Extra space between WKBundlePageTextFieldDidEndEditingCallback and textFieldDidEndEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:135:  Extra space between WKBundlePageTextDidChangeInTextFieldCallback and textDidChangeInTextField  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:136:  Extra space between WKBundlePageTextDidChangeInTextAreaCallback and textDidChangeInTextArea  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 7 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2010-08-06 11:54:31 PDT 
Landed in r64862.