Bug 43594 - Add string forwards to Forward.h
Summary: Add string forwards to Forward.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 17:10 PDT by Gavin Barraclough
Modified: 2010-08-09 17:40 PDT (History)
0 users

See Also:

Attachments
The patch (163.53 KB, patch)
2010-08-05 17:18 PDT, Gavin Barraclough 		barraclough: review+
Details | Formatted Diff | Diff
Patch as landed (162.08 KB, patch)
2010-08-06 16:45 PDT, Gavin Barraclough 		no flags Details | Formatted Diff | Diff
Updated (2.03 KB, patch)
2010-08-06 16:53 PDT, Gavin Barraclough 		no flags Details | Formatted Diff | Diff
Final patch as landed, RS Sam Weinig (590.52 KB, patch)
2010-08-09 17:40 PDT, Gavin Barraclough 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-08-05 17:10:36 PDT 
This allows us to remove forward declarations for these classes from WebCore / WebKit (a step in moving these class from WebCore:: to WTF::).
Comment 1 Gavin Barraclough 2010-08-05 17:18:01 PDT 
Created attachment 63666 [details]
The patch

Rubber stamped by Sam Weinig
Comment 2 Gavin Barraclough 2010-08-05 17:21:22 PDT 
Committed in r64801
Comment 3 Gavin Barraclough 2010-08-06 16:45:31 PDT 
Created attachment 63781 [details]
Patch as landed
Comment 4 Gavin Barraclough 2010-08-06 16:53:07 PDT 
Created attachment 63784 [details]
Updated
Comment 5 Gavin Barraclough 2010-08-09 17:40:53 PDT 
Created attachment 63961 [details]
Final patch as landed, RS Sam Weinig

Landed in r65021, the partial change was problematic on Windows due to conflicts with standard library names on this platform, so landing the full cleanup in one go.