WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43593
WebView::backingStore should check if m_backingStoreBitmap is NULL
https://bugs.webkit.org/show_bug.cgi?id=43593
Summary
WebView::backingStore should check if m_backingStoreBitmap is NULL
Jessie Berlin
Reported
2010-08-05 17:01:24 PDT
There are cases when WebView::backingStore is called while m_backingStoreBitmap is NULL, such as after deleteBackingStore has been called in response to a WM_NCACTIVATE message (indicating a change in the the active/inactive state). Instead of attempting to dereference a null pointer, we should return early with E_FAIL if m_backingStoreBitmap is NULL.
Attachments
Add a null check to WebView::backingStore
(1.07 KB, patch)
2010-08-05 18:49 PDT
,
Jessie Berlin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jessie Berlin
Comment 1
2010-08-05 18:49:12 PDT
Created
attachment 63677
[details]
Add a null check to WebView::backingStore
Jon Honeycutt
Comment 2
2010-08-05 19:05:05 PDT
Comment on
attachment 63677
[details]
Add a null check to WebView::backingStore r=me
Jessie Berlin
Comment 3
2010-08-05 19:19:33 PDT
Comment on
attachment 63677
[details]
Add a null check to WebView::backingStore Committed in
r64811
http://trac.webkit.org/changeset/64811
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug