Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL
Summary: WebView::backingStore should check if m_backingStoreBitmap is NULL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 17:01 PDT by Jessie Berlin
Modified: 2010-08-05 19:19 PDT (History)
1 user (show)

See Also:


Attachments
Add a null check to WebView::backingStore (1.07 KB, patch)
2010-08-05 18:49 PDT, Jessie Berlin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2010-08-05 17:01:24 PDT
There are cases when WebView::backingStore is called while m_backingStoreBitmap is NULL, such as after deleteBackingStore has been called in response to a WM_NCACTIVATE message (indicating a change in the the active/inactive state).

Instead of attempting to dereference a null pointer, we should return early with E_FAIL if m_backingStoreBitmap is NULL.
Comment 1 Jessie Berlin 2010-08-05 18:49:12 PDT
Created attachment 63677 [details]
Add a null check to WebView::backingStore
Comment 2 Jon Honeycutt 2010-08-05 19:05:05 PDT
Comment on attachment 63677 [details]
Add a null check to WebView::backingStore

r=me
Comment 3 Jessie Berlin 2010-08-05 19:19:33 PDT
Comment on attachment 63677 [details]
Add a null check to WebView::backingStore

Committed in r64811
http://trac.webkit.org/changeset/64811