Bug 43585 - Remove Invalid Asserts for Application Cache Quotas
Summary: Remove Invalid Asserts for Application Cache Quotas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 16:06 PDT by Joseph Pecoraro
Modified: 2010-08-05 17:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2010-08-05 16:15 PDT, Joseph Pecoraro
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-08-05 16:06:39 PDT
These ASSERTs were added in:
<http://webkit.org/b/40627> Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)

They will always fail the first time with a client that uses a non-unlimited quota because:
  - ApplicationCacheStorage's singleton is initialized with noQuota defaults
  - WebApplicationCache uses the above singleton
  - When initializing the WebView _preferencesChanged will call setter, which runs this
     ASSERT before the default quota is being set for the first time!

  [WebApplicationCache setDefaultOriginQuota:[preferences applicationCacheDefaultOriginQuota]];
Comment 1 Joseph Pecoraro 2010-08-05 16:15:01 PDT
Created attachment 63658 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2010-08-05 17:05:09 PDT
Comment on attachment 63658 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2010-08-05 17:26:19 PDT
Committed r64802
	M	WebKit/mac/ChangeLog
	M	WebKit/mac/WebView/WebPreferences.mm
r64802 = 71974a4e5fadb1b52f47ea1ab3fcfa7604e2dc86
http://trac.webkit.org/changeset/64802