RESOLVED FIXED Bug 43585
Remove Invalid Asserts for Application Cache Quotas 
https://bugs.webkit.org/show_bug.cgi?id=43585
Summary Remove Invalid Asserts for Application Cache Quotas
Joseph Pecoraro
Reported 2010-08-05 16:06:39 PDT
These ASSERTs were added in: <http://webkit.org/b/40627> Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) They will always fail the first time with a client that uses a non-unlimited quota because: - ApplicationCacheStorage's singleton is initialized with noQuota defaults - WebApplicationCache uses the above singleton - When initializing the WebView _preferencesChanged will call setter, which runs this ASSERT before the default quota is being set for the first time! [WebApplicationCache setDefaultOriginQuota:[preferences applicationCacheDefaultOriginQuota]];
Attachments
Patch (1.67 KB, patch)
2010-08-05 16:15 PDT, Joseph Pecoraro 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-08-05 16:15:01 PDT
Created attachment 63658 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2010-08-05 17:05:09 PDT
Comment on attachment 63658 [details] Patch r=me
Joseph Pecoraro
Comment 3 2010-08-05 17:26:19 PDT
Committed r64802 M WebKit/mac/ChangeLog M WebKit/mac/WebView/WebPreferences.mm r64802 = 71974a4e5fadb1b52f47ea1ab3fcfa7604e2dc86 http://trac.webkit.org/changeset/64802
Note You need to log in before you can comment on or make changes to this bug.