WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43570
Add VisitedLinkProvider class
https://bugs.webkit.org/show_bug.cgi?id=43570
Summary
Add VisitedLinkProvider class
Anders Carlsson
Reported
2010-08-05 12:13:37 PDT
Add VisitedLinkProvider class
Attachments
Patch
(16.73 KB, patch)
2010-08-05 12:19 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-08-05 12:19:17 PDT
Created
attachment 63615
[details]
Patch
WebKit Review Bot
Comment 2
2010-08-05 12:20:30 PDT
Attachment 63615
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/VisitedLinkProvider.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/WebProcess.cpp:180: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebKit2/UIProcess/VisitedLinkProvider.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2010-08-05 12:52:09 PDT
Comment on
attachment 63615
[details]
Patch Awesome!
Anders Carlsson
Comment 4
2010-08-05 12:54:47 PDT
Committed
r64775
: <
http://trac.webkit.org/changeset/64775
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug