Bug 43548 - Allow custom memory allocation control for EventHandlingState struct
Summary: Allow custom memory allocation control for EventHandlingState struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 02:52 PDT by Zoltan Horvath
Modified: 2010-08-07 22:01 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (1.24 KB, patch)
2010-08-05 02:55 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2010-08-05 02:52:17 PDT 
Inherits the following class from FastAllocBase because it is instantiated by 'new':

struct name: EventHandlingState; instantiated at: WebCore/html/HTMLInputElement.cpp:2051
Comment 1 Zoltan Horvath 2010-08-05 02:55:12 PDT 
Created attachment 63568 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2010-08-06 13:32:01 PDT 
Comment on attachment 63568 [details]
proposed patch

Are you using a script to find these?  Could we add a script to the build system to catch these before checkin?
Comment 3 Zoltan Horvath 2010-08-06 13:37:27 PDT 
Unfortunately, not. I'm using our static code analyzer tool called Columbus to catch these. It's a continuous work, I make analyses once a week and usually I need a little hand-check on the results before posting bugs.
Comment 4 Eric Seidel (no email) 2010-08-07 22:01:14 PDT 
Comment on attachment 63568 [details]
proposed patch

Clearing flags on attachment: 63568

Committed r64936: <http://trac.webkit.org/changeset/64936>
Comment 5 Eric Seidel (no email) 2010-08-07 22:01:18 PDT 
All reviewed patches have been landed.  Closing bug.