RESOLVED FIXED 43544
[EFL]Implementation dispatchDecidePolicyForNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=43544
Summary [EFL]Implementation dispatchDecidePolicyForNavigationAction
Ryuan Choi
Reported 2010-08-05 01:57:24 PDT
I want to call some other application when user click mailto. I think that FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction is proper function.
Attachments
Patch (10.41 KB, patch)
2010-08-05 02:16 PDT, Ryuan Choi
no flags
Patch (11.13 KB, patch)
2010-08-05 04:13 PDT, Ryuan Choi
no flags
Patch (4.86 KB, patch)
2010-08-05 19:40 PDT, Ryuan Choi
no flags
proposed patch (4.85 KB, patch)
2010-08-05 22:40 PDT, Ryuan Choi
no flags
Patch (5.03 KB, patch)
2010-08-08 23:10 PDT, Ryuan Choi
no flags
Ryuan Choi
Comment 1 2010-08-05 02:16:57 PDT
Ryuan Choi
Comment 2 2010-08-05 04:13:45 PDT
Ryuan Choi
Comment 3 2010-08-05 19:40:12 PDT
Ryuan Choi
Comment 4 2010-08-05 22:40:29 PDT
Created attachment 63694 [details] proposed patch Sorry I found wrong EAPI option in ewk_private.h. I removed
Antonio Gomes
Comment 5 2010-08-06 09:16:44 PDT
Comment on attachment 63694 [details] proposed patch I think it looks good. I have one question: > + > + PolicyAction policy; > + if (!ret) > + policy = PolicyIgnore; > + else { > + Frame* f = ewk_frame_core_get(m_frame); > + f->loader()->resetMultipleFormSubmissionProtection(); > + policy = PolicyUse; > + } You are unconditionally calling resetMultipleFormSubmissionProtection() . Should not you do so only with the NavicationAction involves that? Se Qt's code below: if (!page->d->acceptNavigationRequest(m_webFrame, r, QWebPage::NavigationType(action.type()))) { if (action.type() == NavigationTypeFormSubmitted || action.type() == NavigationTypeFormResubmitted) m_frame->loader()->resetMultipleFormSubmissionProtection();
Ryuan Choi
Comment 6 2010-08-08 19:46:28 PDT
(In reply to comment #5) > (From update of attachment 63694 [details]) > I think it looks good. I have one question: > > > + > > + PolicyAction policy; > > + if (!ret) > > + policy = PolicyIgnore; > > + else { > > + Frame* f = ewk_frame_core_get(m_frame); > > + f->loader()->resetMultipleFormSubmissionProtection(); > > + policy = PolicyUse; > > + } > > > You are unconditionally calling resetMultipleFormSubmissionProtection() . Should not you do so only with the NavicationAction involves that? > > Se Qt's code below: > > if (!page->d->acceptNavigationRequest(m_webFrame, r, QWebPage::NavigationType(action.type()))) { > if (action.type() == NavigationTypeFormSubmitted || action.type() == NavigationTypeFormResubmitted) > m_frame->loader()->resetMultipleFormSubmissionProtection(); Ok, I'll add action related code
Ryuan Choi
Comment 7 2010-08-08 23:10:12 PDT
Antonio Gomes
Comment 8 2010-08-11 08:44:34 PDT
Comment on attachment 63859 [details] Patch r=me
WebKit Commit Bot
Comment 9 2010-08-11 10:15:23 PDT
Comment on attachment 63859 [details] Patch Clearing flags on attachment: 63859 Committed r65163: <http://trac.webkit.org/changeset/65163>
WebKit Commit Bot
Comment 10 2010-08-11 10:15:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.