Bug 43542 - [chromium] WidgetChromium does not need to notify the ChromeClient when it gets focused
Summary: [chromium] WidgetChromium does not need to notify the ChromeClient when it ge...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 00:16 PDT by Jay Civelli
Modified: 2010-08-07 21:48 PDT (History)
1 user (show)

See Also:

Attachments
Initial patch (2.69 KB, patch)
2010-08-05 00:23 PDT, Jay Civelli 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-08-05 00:16:04 PDT 
WidgetChromium notifies the ChromeClient (via the ChromiumBridge) of every setFocus call.
This is called every time a new node gets focused and is not used. (There is a ChromeClient::focusedNodeChange() that notifies every time a new node gets focused.)
Calls to window.focus()/blur() are directly passed to the ChromeClient in WebCore/Chrome.cpp.

For these reasons WidgetChromium::setFocus() should not do anything and the corresponding code in ChromiumBridge should be cleaned.
Comment 1 Jay Civelli 2010-08-05 00:23:13 PDT 
Created attachment 63562 [details]
Initial patch
Comment 2 Eric Seidel (no email) 2010-08-06 14:43:14 PDT 
Comment on attachment 63562 [details]
Initial patch

Yay!
Comment 3 Eric Seidel (no email) 2010-08-07 21:48:06 PDT 
Comment on attachment 63562 [details]
Initial patch

Clearing flags on attachment: 63562

Committed r64935: <http://trac.webkit.org/changeset/64935>
Comment 4 Eric Seidel (no email) 2010-08-07 21:48:10 PDT 
All reviewed patches have been landed.  Closing bug.