Bug 43534 - Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
Summary: Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-04 19:50 PDT by Antonio Gomes
Modified: 2010-08-24 02:50 PDT (History)
3 users (show)

See Also:

Attachments
(committed with r64705, r=daniel bates) patch v1 (2.97 KB, patch)
2010-08-04 19:55 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-08-04 19:50:18 PDT 
As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 , the non-negative checks present in both paddingWidth and paddingHeight methods of HitTestResults class are superflous, after we changed the rect based hit testing logic of invalid padding  from IntSize(-1, -1) to IntSize(0, 0).

I missed updating these two method while addressing last hyatt's reviews.

Patch coming.
Comment 1 Antonio Gomes 2010-08-04 19:55:25 PDT 
Created attachment 63536 [details]
(committed with r64705, r=daniel bates) patch v1
Comment 2 Daniel Bates 2010-08-04 20:14:04 PDT 
Comment on attachment 63536 [details]
(committed with r64705, r=daniel bates) patch v1

Looks sane to me.
r=me.
Comment 3 Antonio Gomes 2010-08-04 20:29:33 PDT 
Comment on attachment 63536 [details]
(committed with r64705, r=daniel bates) patch v1

Clearing flags on attachment: 63536

Committed r64705: <http://trac.webkit.org/changeset/64705>
Comment 4 Simon Hausmann 2010-08-24 01:39:11 PDT 
Revision r64705 cherry-picked into qtwebkit-2.1 with commit 40071b732cbe2fe02f738c04d01da6e35ba84bac