Bug 43533 - When DEVICE_ORIENTATION is enabled, m_client always ASSERTS
Summary: When DEVICE_ORIENTATION is enabled, m_client always ASSERTS
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-04 19:20 PDT by Dean Jackson
Modified: 2010-08-05 02:08 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2010-08-04 19:20:34 PDT 
If you simply build with DEVICE_ORIENTATION enabled, 

DeviceOrientationController::DeviceOrientationController(WebCore::Page*, WebCore::DeviceOrientationClient*))

will always assert because there is no client created in the default build.
Comment 1 Steve Block 2010-08-05 02:08:01 PDT 
This is working as intended. DeviceOrientation, like most features, requires that a non-null client is supplied. Platforms need to make sure that they supply non-null clients for all such features they choose to enable. See the comment for the PageClients structure in Page.h.