Bug 43499 – WebKit2 on Windows should use Windows fonts for the various standard font families

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Adam Roben (:aroben)]

WebKit2 on Windows (specifically, WebPreferencesStore) currently uses Mac fonts for the various standard font families. But we should use Windows fonts instead!

[Adam Roben (:aroben)]

<rdar://problem/8272758>

[Jon Honeycutt]

Created attachment 69299 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 69299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69299&action=review

> WebKitTools/WebKitTestRunner/TestController.cpp:216
> +    static WKStringRef standardFontFamily = WKStringCreateWithCFString(CFSTR("Times"));
> +    static WKStringRef cursiveFontFamily = WKStringCreateWithCFString(CFSTR("Apple Chancery"));
> +    static WKStringRef fantasyFontFamily = WKStringCreateWithCFString(CFSTR("Papyrus"));
> +    static WKStringRef fixedFontFamily = WKStringCreateWithCFString(CFSTR("Courier"));
> +    static WKStringRef sansSerifFontFamily = WKStringCreateWithCFString(CFSTR("Helvetica"));
> +    static WKStringRef serifFontFamily = WKStringCreateWithCFString(CFSTR("Times"));

This is going to upset people in bug 45393, but there's no other way right now.

[Darin Adler]

Comment on attachment 69299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69299&action=review

> WebKit2/Shared/WebPreferencesStore.cpp:48
> +#if PLATFORM(WIN)

Should this be WIN or !MAC?

[Jon Honeycutt]

(In reply to comment #4)
> (From update of attachment 69299 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69299&action=review
> 
> > WebKit2/Shared/WebPreferencesStore.cpp:48
> > +#if PLATFORM(WIN)
> 
> Should this be WIN or !MAC?

I'm not sure if any other platforms are using this code, so I'll only change Windows for now.

[Jon Honeycutt]

Landed in r68849.