Bug 43499 - WebKit2 on Windows should use Windows fonts for the various standard font families
Summary: WebKit2 on Windows should use Windows fonts for the various standard font fam...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-08-04 11:52 PDT by Adam Roben (:aroben)
Modified: 2010-09-30 16:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.68 KB, patch)
2010-09-29 19:49 PDT, Jon Honeycutt 		aroben: review+
jhoneycutt: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-08-04 11:52:19 PDT 
WebKit2 on Windows (specifically, WebPreferencesStore) currently uses Mac fonts for the various standard font families. But we should use Windows fonts instead!
Comment 1 Adam Roben (:aroben) 2010-08-04 11:52:49 PDT 
<rdar://problem/8272758>
Comment 2 Jon Honeycutt 2010-09-29 19:49:25 PDT 
Created attachment 69299 [details]
Patch
Comment 3 Adam Roben (:aroben) 2010-09-30 04:13:41 PDT 
Comment on attachment 69299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69299&action=review

> WebKitTools/WebKitTestRunner/TestController.cpp:216
> +    static WKStringRef standardFontFamily = WKStringCreateWithCFString(CFSTR("Times"));
> +    static WKStringRef cursiveFontFamily = WKStringCreateWithCFString(CFSTR("Apple Chancery"));
> +    static WKStringRef fantasyFontFamily = WKStringCreateWithCFString(CFSTR("Papyrus"));
> +    static WKStringRef fixedFontFamily = WKStringCreateWithCFString(CFSTR("Courier"));
> +    static WKStringRef sansSerifFontFamily = WKStringCreateWithCFString(CFSTR("Helvetica"));
> +    static WKStringRef serifFontFamily = WKStringCreateWithCFString(CFSTR("Times"));

This is going to upset people in bug 45393, but there's no other way right now.
Comment 4 Darin Adler 2010-09-30 11:24:45 PDT 
Comment on attachment 69299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69299&action=review

> WebKit2/Shared/WebPreferencesStore.cpp:48
> +#if PLATFORM(WIN)

Should this be WIN or !MAC?
Comment 5 Jon Honeycutt 2010-09-30 15:40:14 PDT 
(In reply to comment #4)
> (From update of attachment 69299 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69299&action=review
> 
> > WebKit2/Shared/WebPreferencesStore.cpp:48
> > +#if PLATFORM(WIN)
> 
> Should this be WIN or !MAC?

I'm not sure if any other platforms are using this code, so I'll only change Windows for now.
Comment 6 Jon Honeycutt 2010-09-30 16:18:27 PDT 
Landed in r68849.