Bug 43497 - NetscapePluginModule::try/unload should be cross-platform
Summary: NetscapePluginModule::try/unload should be cross-platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 43189 43513
  Show dependency tree / graph
 
Reported: 2010-08-04 11:39 PDT by Adam Roben (:aroben)
Modified: 2010-08-05 07:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch (25.21 KB, patch)
2010-08-04 11:45 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-08-04 11:39:24 PDT 
NetscapePluginModule::try/unload should be cross-platform
Comment 1 Adam Roben (:aroben) 2010-08-04 11:45:40 PDT 
Created attachment 63474 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-04 11:47:59 PDT 
Attachment 63474 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Platform/win/ModuleWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Platform/qt/ModuleQt.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Platform/Module.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-08-04 12:02:15 PDT 
Comment on attachment 63474 [details]
Patch

On mac, Module::unload should always leak the bundle, it's not specific to plug-ins.

Looks great otherwise!
Comment 4 Adam Roben (:aroben) 2010-08-04 12:10:27 PDT 
Committed r64663: <http://trac.webkit.org/changeset/64663>
Comment 5 Adam Roben (:aroben) 2010-08-04 12:29:26 PDT 
Committed r64664: <http://trac.webkit.org/changeset/64664>
Comment 6 Adam Roben (:aroben) 2010-08-04 12:37:36 PDT 
Committed r64666: <http://trac.webkit.org/changeset/64666>
Comment 7 Adam Roben (:aroben) 2010-08-04 12:50:13 PDT 
Committed r64667: <http://trac.webkit.org/changeset/64667>
Comment 8 Adam Roben (:aroben) 2010-08-04 12:58:19 PDT 
Committed r64668: <http://trac.webkit.org/changeset/64668>