Created attachment 63459 [details] patch The collector code currently generates a number of style errors. Additionally, the new WTF::Bitmap class can be used to as an almost drop in replacement to the current bitmap in JSC::Heap.
Attachment 63459 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/runtime/Collector.cpp:641: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] JavaScriptCore/runtime/Collector.cpp:653: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] JavaScriptCore/runtime/Collector.h:73: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 63459 [details] patch r=me
Comment on attachment 63459 [details] patch Rejecting patch 63459 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Oliver Hunt', u'--force']" exit_code: 1 Last 500 characters of output: JavaScriptCore/runtime/Collector.cpp Hunk #1 succeeded at 282 (offset 2 lines). Hunk #2 succeeded at 329 (offset 2 lines). Hunk #3 succeeded at 640 (offset 2 lines). Hunk #4 succeeded at 652 (offset 2 lines). Hunk #5 succeeded at 681 (offset 2 lines). Hunk #6 succeeded at 1055 (offset 2 lines). Hunk #7 succeeded at 1068 (offset 2 lines). patching file JavaScriptCore/runtime/Collector.h Hunk #2 FAILED at 58. 1 out of 4 hunks FAILED -- saving rejects to file JavaScriptCore/runtime/Collector.h.rej Full output: http://queues.webkit.org/results/3658191
Created attachment 63651 [details] patch (up to date)
Attachment 63651 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/runtime/Collector.cpp:643: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] JavaScriptCore/runtime/Collector.cpp:655: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] JavaScriptCore/runtime/Collector.h:73: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 63651 [details] patch (up to date) Rejecting patch 63651 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Oliver Hunt', u'--force']" exit_code: 1 Last 500 characters of output: at 643 (offset 3 lines). Hunk #4 succeeded at 655 (offset 3 lines). Hunk #5 succeeded at 684 (offset 3 lines). Hunk #6 succeeded at 1090 (offset 35 lines). Hunk #7 succeeded at 1103 (offset 35 lines). patching file JavaScriptCore/runtime/Collector.h Hunk #1 succeeded at 41 (offset 1 line). Hunk #2 FAILED at 59. Hunk #3 succeeded at 226 (offset 8 lines). Hunk #4 succeeded at 271 with fuzz 1 (offset 8 lines). 1 out of 4 hunks FAILED -- saving rejects to file JavaScriptCore/runtime/Collector.h.rej Full output: http://queues.webkit.org/results/3601784
Created attachment 63740 [details] patch (up to date)
Attachment 63740 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/runtime/Collector.cpp:646: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] JavaScriptCore/runtime/Collector.cpp:658: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] JavaScriptCore/runtime/Collector.h:74: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 63459 [details] patch Cleared Oliver Hunt's review+ from obsolete attachment 63459 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment on attachment 63651 [details] patch (up to date) Cleared Oliver Hunt's review+ from obsolete attachment 63651 [details] so that this bug does not appear in http://webkit.org/pending-commit.
I assume this was landed. Please re-open with an up-to-date patch if I'm wrong.