Bug 43485 – [GTK] 407 page contents prepended to desired page contents

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Barry Scott]

To the SoupSeesion add an implementation of SoupProxyURIResolver.
When the first request goes through the body of the 407 response
is combined with the desired pages body.

The 2nd and subsequent load_url() calls to webkit work as expect
(SoupLogger shows that the ProxyAuth head is always sent).

The following patch suggested by danw fixed the problem.

--- WebCore/platform/network/soup/ResourceHandleSoup.cpp~       2010-08-04 15:08:43.364294079 +0100
+++ WebCore/platform/network/soup/ResourceHandleSoup.cpp        2010-08-04 15:08:43.365413474 +0100
@@ -153,7 +153,8 @@
 {
     if (SOUP_STATUS_IS_TRANSPORT_ERROR(statusCode)
         || (SOUP_STATUS_IS_REDIRECTION(statusCode) && (statusCode != SOUP_STATUS_NOT_MODIFIED))
-        || (statusCode == SOUP_STATUS_UNAUTHORIZED))
+        || (statusCode == SOUP_STATUS_UNAUTHORIZED)
+        || (statusCode == SOUP_STATUS_PROXY_UNAUTHORIZED))
         return true;
 
     return false;

[Sergio Villar Senin]

Barry could you please add the patch as an attachment setting the review flag to '?'

That way a WebKit reviewer could take a look and approve it.

[Barry Scott]

Created attachment 66857 [details]
Patch that fixes the 407 handling bug.

[WebKit Review Bot]

Attachment 66857 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gustavo Noronha (kov)]

Comment on attachment 66857 [details]
Patch that fixes the 407 handling bug.

This looks right to me, but the patche needs a ChangeLog entry as well, could you please add it? There's some information on how here:

http://webkit.org/coding/contributing.html

[Barry Scott]

Created attachment 67392 [details]
Patch that fixes the 407 handling bug. With ChangeLog.

Hopefully this is what you need.

[Martin Robinson]

Comment on attachment 67392 [details]
Patch that fixes the 407 handling bug. With ChangeLog.

View in context: https://bugs.webkit.org/attachment.cgi?id=67392&action=prettypatch

Great change, but if this can be tested it should have tests.

> WebCore/ChangeLog:19
> +        No new tests. (OOPS!)
There should either be tests for this patch or an explanation here of why this cannot be tested.

[Barry Scott]

Explanation no tests:

I have no idea what your test framework requires.

I have no time to learn about this and develop a
test to your standards.

[Martin Robinson]

Sergio, any comments on this issue?

[Sergio Villar Senin]

(In reply to comment #8)
> Sergio, any comments on this issue?

I would try to complete the patch with a proper test

[Dominik Röttsches (drott)]

(In reply to comment #0)
> To the SoupSeesion add an implementation of SoupProxyURIResolver.
> When the first request goes through the body of the 407 response
> is combined with the desired pages body.
> 
> The 2nd and subsequent load_url() calls to webkit work as expect
> (SoupLogger shows that the ProxyAuth head is always sent).
> 
> The following patch suggested by danw fixed the problem.

Barry, can you still reproduce this issue?

How did you find the bug? What are the reproduction steps?

[Barry Scott]

(In reply to comment #10)
> (In reply to comment #0)
> > To the SoupSeesion add an implementation of SoupProxyURIResolver.
> > When the first request goes through the body of the 407 response
> > is combined with the desired pages body.
> > 
> > The 2nd and subsequent load_url() calls to webkit work as expect
> > (SoupLogger shows that the ProxyAuth head is always sent).
> > 
> > The following patch suggested by danw fixed the problem.
> 
> Barry, can you still reproduce this issue?
> 
> How did you find the bug? What are the reproduction steps?

I think you need to test against a proxy that is password protected.

We test with "no auth", "basic" and "digest" in all combinations
for the web page and the proxy. e.g. 9 tests. In the ones where
the proxy needs authenticated the page output is corrupted.

You have rewritten the Soup code in this area for current webkitgtk
so that this patch is not needed and the bug is no longer present.

[Dominik Röttsches (drott)]

Barry, thanks for the quick feedback. Closing according to reporter.