Bug 43479 - DevTools: get rid of delayed command dispatching on front-end side.
Summary: DevTools: get rid of delayed command dispatching on front-end side.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-04 05:13 PDT by Pavel Feldman
Modified: 2010-08-05 03:01 PDT (History)
3 users (show)

See Also:


Attachments
[PATCH] Proposed change. (11.61 KB, patch)
2010-08-04 05:16 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff
[PATCH] To land. (12.84 KB, patch)
2010-08-05 02:55 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-08-04 05:13:56 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-08-04 05:16:46 PDT
Created attachment 63442 [details]
[PATCH] Proposed change.
Comment 2 WebKit Review Bot 2010-08-04 05:18:40 PDT
Attachment 63442 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp:67:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp:132:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yury Semikhatsky 2010-08-04 05:29:12 PDT
Comment on attachment 63442 [details]
[PATCH] Proposed change.

WebKit/chromium/src/js/Tests.js:1856
 +  WebInspector.showElementsPanel = function()
Could you override another method that wouldn't depend on the fact that the elements panel should be shown? WebInspector.Panel.show may be a good candidate?
Comment 4 Pavel Feldman 2010-08-04 06:13:37 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/public/WebDevToolsAgent.h
	M	WebKit/chromium/src/WebDevToolsAgentImpl.cpp
	M	WebKit/chromium/src/WebDevToolsAgentImpl.h
Committed r64646
Comment 5 Pavel Feldman 2010-08-05 02:55:07 PDT
Created attachment 63567 [details]
[PATCH] To land.
Comment 6 Pavel Feldman 2010-08-05 03:01:24 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/inspector/front-end/InspectorBackendStub.js
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/public/WebDevToolsFrontendClient.h
	M	WebKit/chromium/src/WebDevToolsAgentImpl.cpp
	M	WebKit/chromium/src/WebDevToolsAgentImpl.h
	M	WebKit/chromium/src/WebDevToolsFrontendImpl.cpp
	M	WebKit/chromium/src/WebDevToolsFrontendImpl.h
	M	WebKit/chromium/src/js/DevTools.js
	M	WebKit/chromium/src/js/Tests.js
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.h
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.h
Committed r64729