Bug 43469 - <noscript> works the other way around in some cases when xhtmlmp enabled
Summary: <noscript> works the other way around in some cases when xhtmlmp enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-04 00:09 PDT by Charles Wei
Modified: 2010-08-05 06:20 PDT (History)
2 users (show)

See Also:

Attachments
html file that demos the bug (378 bytes, application/xhtml+xml)
2010-08-04 00:09 PDT, Charles Wei 		no flags Details
The patch (2.90 KB, patch)
2010-08-04 00:56 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2010-08-04 00:09:48 PDT 
Created attachment 63422 [details]
html file that demos the bug

<noscript> should be processed when the Javascript is DISABLED and should be ignored when javascript is ENABLED.  

But with WebKit,  if you enable xhtmlmp ,  noscript works the other way around in some cases, that is,  <noscript> is processed and rendered when javascript is ENABLED,  and is ignored when Javascript is DISABLED.

The attachment reveals it. Please note,  you need to turn on xhtmlmp support to reproduce this.
Comment 1 Charles Wei 2010-08-04 00:56:06 PDT 
Created attachment 63426 [details]
The patch

This patch fixes the problem.   The logic was oppositely wrong in deciding if <noscript> should be processed.
Comment 2 WebKit Commit Bot 2010-08-05 06:20:18 PDT 
Comment on attachment 63426 [details]
The patch

Clearing flags on attachment: 63426

Committed r64740: <http://trac.webkit.org/changeset/64740>
Comment 3 WebKit Commit Bot 2010-08-05 06:20:22 PDT 
All reviewed patches have been landed.  Closing bug.