Bug 43466 – NRWT: websocket_server startup detection failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kent Tamura]

websocket_server startup detection sometimes fails on Chromium Windows and Chromium Mac bots.

http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/950/steps/layout-test/logs/stdio
http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/1121/steps/layout-test/logs/stdio

Traceback (most recent call last):
  File "./WebKitTools/Scripts/new-run-webkit-tests", line 38, in <module>
    sys.exit(run_webkit_tests.main())
  File "/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 1677, in main
    return run(port_obj, options, args)
  File "/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 1441, in run
    num_unexpected_results = test_runner.run(result_summary)
  File "/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 754, in run
    self._port.start_websocket_server()
  File "/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py", line 467, in start_websocket_server
    self._websocket_server.start()
  File "/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/port/websocket_server.py", line 219, in start
    (self._server_name, self._port))
webkitpy.layout_tests.port.websocket_server.PyWebSocketNotStarted: Failed to start PyWebSocket server on port 8880.

It seems url_is_live() unexpectedly returns False.

[Kent Tamura]

Created attachment 63414 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 63414 [details]
Patch

ok.

[Kent Tamura]

Comment on attachment 63414 [details]
Patch

Clearing flags on attachment: 63414

Committed r64708: <http://trac.webkit.org/changeset/64708>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.