Bug 43445 - [GTK] Use correct path for Inspector data files in GTK+3.x builds
Summary: [GTK] Use correct path for Inspector data files in GTK+3.x builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-03 14:22 PDT by Xan Lopez
Modified: 2010-08-05 08:37 PDT (History)
1 user (show)

See Also:

Attachments
datainspector.diff (2.31 KB, patch)
2010-08-03 14:24 PDT, Xan Lopez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-08-03 14:22:31 PDT 
SSIA.
Comment 1 Xan Lopez 2010-08-03 14:24:34 PDT 
Created attachment 63376 [details]
datainspector.diff
Comment 2 Martin Robinson 2010-08-03 15:02:59 PDT 
This patch seems sane to me. Perhaps adding a WEBKITGTK_API_VERSION define and setting it to @WEBKITGTK_API_VERSION@ would make this bit of code future proof though. Then the path could just be:

inspectorURI.set(g_filename_to_uri(DATA_DIR"/webkit-"WEBKITGTK_API_VERSION"/webinspector/inspector.html"
Comment 3 Xan Lopez 2010-08-03 15:27:37 PDT 
Comment on attachment 63376 [details]
datainspector.diff

Martin is right, we should do as he says. I'll upload a patch doing that tomorrow.
Comment 4 Xan Lopez 2010-08-05 08:37:23 PDT 
The patch suggested by Martin was committed as r64752, closing.