Bug 43443 – Accelerometer tests need V8 results

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dean Jackson]

The new test fast/dom/Accelerometer/window-property.html does not pass with v8. It needs platform-specific results.

[Steve Block]

Created attachment 63950 [details]
Patch

[Jeremy Orlow]

Comment on attachment 63950 [details]
Patch

r=me

[Jeremy Orlow]

Hans, can you please make a patch that sets the expected results for Chromium as well?

[Hans Wennborg]

(In reply to comment #3)
> Hans, can you please make a patch that sets the expected results for Chromium as well?

Will do once we enable it.

[WebKit Commit Bot]

Comment on attachment 63950 [details]
Patch

Rejecting patch 63950 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20806 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 14219 tests run.
252.83s total testing time

14218 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://queues.webkit.org/results/3730017

[Steve Block]

Comment on attachment 63950 [details]
Patch

Queue failure looks like flakiness. Trying again.

[WebKit Commit Bot]

Comment on attachment 63950 [details]
Patch

Rejecting patch 63950 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20806 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 14219 tests run.
249.35s total testing time

14218 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://queues.webkit.org/results/3747017

[Steve Block]

Committed r65066: <http://trac.webkit.org/changeset/65066>

[Eric Seidel (no email)]

Did it flake twice? or did this really cause a regression?  Either way, we should get a bug on the flaky test so it can be fixed.

[Steve Block]

> Did it flake twice?
Yes, it did. I couldn't reproduce the failure locally so I landed manually and it didn't seem to cause any failures in the continuous build.

Would you like me to file a bug against the test or against the commit queue?

[Eric Seidel (no email)]

In a perfect world, anytime we see a test flake (on the commit-queue or build.webkit.org) we should file a bug.

[Steve Block]

Have filed Bug 43840 to track the test flakiness