Bug 43443 - Accelerometer tests need V8 results
Summary: Accelerometer tests need V8 results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 42865
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-03 13:42 PDT by Dean Jackson
Modified: 2010-08-11 02:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.19 KB, patch)
2010-08-09 16:30 PDT, Steve Block
jorlow: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2010-08-03 13:42:46 PDT
The new test fast/dom/Accelerometer/window-property.html does not pass with v8. It needs platform-specific results.
Comment 1 Steve Block 2010-08-09 16:30:56 PDT
Created attachment 63950 [details]
Patch
Comment 2 Jeremy Orlow 2010-08-10 02:01:53 PDT
Comment on attachment 63950 [details]
Patch

r=me
Comment 3 Jeremy Orlow 2010-08-10 02:02:39 PDT
Hans, can you please make a patch that sets the expected results for Chromium as well?
Comment 4 Hans Wennborg 2010-08-10 02:29:00 PDT
(In reply to comment #3)
> Hans, can you please make a patch that sets the expected results for Chromium as well?

Will do once we enable it.
Comment 5 WebKit Commit Bot 2010-08-10 02:57:44 PDT
Comment on attachment 63950 [details]
Patch

Rejecting patch 63950 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20806 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 14219 tests run.
252.83s total testing time

14218 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://queues.webkit.org/results/3730017
Comment 6 Steve Block 2010-08-10 03:13:31 PDT
Comment on attachment 63950 [details]
Patch

Queue failure looks like flakiness. Trying again.
Comment 7 WebKit Commit Bot 2010-08-10 03:37:36 PDT
Comment on attachment 63950 [details]
Patch

Rejecting patch 63950 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20806 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 14219 tests run.
249.35s total testing time

14218 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://queues.webkit.org/results/3747017
Comment 8 Steve Block 2010-08-10 04:22:01 PDT
Committed r65066: <http://trac.webkit.org/changeset/65066>
Comment 9 Eric Seidel (no email) 2010-08-10 10:01:15 PDT
Did it flake twice? or did this really cause a regression?  Either way, we should get a bug on the flaky test so it can be fixed.
Comment 10 Steve Block 2010-08-10 12:50:32 PDT
> Did it flake twice?
Yes, it did. I couldn't reproduce the failure locally so I landed manually and it didn't seem to cause any failures in the continuous build.

Would you like me to file a bug against the test or against the commit queue?
Comment 11 Eric Seidel (no email) 2010-08-10 14:42:15 PDT
In a perfect world, anytime we see a test flake (on the commit-queue or build.webkit.org) we should file a bug.
Comment 12 Steve Block 2010-08-11 02:05:48 PDT
Have filed Bug 43840 to track the test flakiness