Bug 43440 – <noscript> is not allowed inside <p>

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Mathias Bynens]

Here's a "demo" page where the issue occurs: http://jsperf.com/slugs Note that this document validates as HTML5.

I wasn't sure what to do with this, so I asked #whatwg: http://krijnhoetmer.nl/irc-logs/whatwg/20100803#l-952

# [21:20] <Matjas> What is up with this? Web Inspector gives the following error: "<noscript> is not allowed inside <p>" Screenshot: http://i.imgur.com/rQSRl.png  
# [21:21] <Matjas> But the HTML validates and everything… Is this is a Webkit bug or am I doing something wrong?  
# [21:21] <annevk5> sounds like a WebKit bug  
# [21:23] <Matjas> annevk5: http://www.w3.org/TR/REC-html40/interact/scripts.html#h-18.3.1 says "<!ELEMENT NOSCRIPT - - (%block;)+ "  
# [21:23] <Matjas> (That's from HTML4 though)  
# [21:24] <annevk5> HTML4 does not seem relevant  
# [21:24] <annevk5> and that does not tell anything about what <p> allows  
# [21:24] <annevk5> though I guess if <noscript> just allows %block; <p> does not allow <noscript>  
# [21:24] <annevk5> but still a bug in WebKit

[Mathias Bynens]

Cross-posted on crbug.com, as recommended by Paul Irish: http://code.google.com/p/chromium/issues/detail?id=51085

[Alexey Proskuryakov]

I can reproduce this with both Safari/WebKit 5 and ToT. Indeed, this seems to be something HTML4 didn't allow.

[Adam Barth]

This is likely to get fixed today or tomorrow when we turn on the HTML5 tree builder.

[Peter Beverloo]

I can confirm Adam's comment, the error no longer appears.

[Adam Barth]

Great!

[Alexey Proskuryakov]

Adam, do we want to make and land a regression test?

[Adam Barth]

I believe this case is already tested in the html5lib test suite, but we can add another test if you want to be sure.

[Adam Barth]

Reopening to add a test.

[Adam Barth]

Created attachment 63619 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 63619 [details]
Patch

Clearing flags on attachment: 63619

Committed r64838: <http://trac.webkit.org/changeset/64838>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Mathias Bynens]

*** Bug 51254 has been marked as a duplicate of this bug. ***