Bug 43432 - MathML merror element style adjustments
Summary: MathML merror element style adjustments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-03 09:55 PDT by François Sausset
Modified: 2010-08-05 01:46 PDT (History)
1 user (show)

See Also:


Attachments
Patch (973 bytes, patch)
2010-08-03 09:57 PDT, François Sausset
no flags Details | Formatted Diff | Diff
Test case (371 bytes, application/xhtml+xml)
2010-08-03 13:07 PDT, François Sausset
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description François Sausset 2010-08-03 09:55:31 PDT
The default style of merror should make it easily detectable when reading a MathML rendering.
A patch that makes merror more clearly detectable and that roughly matches Mozilla behaviour will follow to have a consistent behaviour between different MathML implementations as the MathML3 specification let some freedom about merror style:
http://www.w3.org/TR/MathML3/chapter3.html#presm.merror
Comment 1 François Sausset 2010-08-03 09:57:49 PDT
Created attachment 63344 [details]
Patch
Comment 2 Darin Adler 2010-08-03 12:34:26 PDT
Comment on attachment 63344 [details]
Patch

Can we add a test case for this? We should be able to see this with getComputedStyle, so it could be tested with a dumpAsText-style test.
Comment 3 François Sausset 2010-08-03 13:07:01 PDT
Created attachment 63370 [details]
Test case

Test case adapted from the MathML 3 test suite example.

I don't understand what do you mean by "dumpAsText-style test". I'm quite new to WebKit development and I don't know all the subtleties.
Should I include the test in LayoutTests by submitting a new patch with expected results? Or do you suggest something else?
Comment 4 WebKit Commit Bot 2010-08-05 01:46:08 PDT
Comment on attachment 63344 [details]
Patch

Clearing flags on attachment: 63344

Committed r64723: <http://trac.webkit.org/changeset/64723>
Comment 5 WebKit Commit Bot 2010-08-05 01:46:13 PDT
All reviewed patches have been landed.  Closing bug.