Bug 43429 – [GTK] Does not paint the node highlight used by the inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Gustavo Noronha (kov)]

When using the "inspect" tool of the inspector, or when hovering the mouse over elements in the inspector, the nodes are not highlighted.

[Gustavo Noronha (kov)]

Created attachment 63341 [details]
proposed patch

[Xan Lopez]

Comment on attachment 63341 [details]
proposed patch

>-void InspectorClient::highlight(Node* node)
>+void InspectorClient::highlight(Node*)
> {
>-    notImplemented();
>+    hideHighlight();
> }
> 
> void InspectorClient::hideHighlight()
> {
>-    notImplemented();
>+    // FIXME: we should be able to only invalidate the actual rects of
>+    // the new and old nodes. We need to track the nodes, and take the
>+    // actual highlight size into account when calculating the damage
>+    // rect.
>+    gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView));
> }

There's some huge epic fail in naming going on here ;)


>+        ctx.save();
>+        ctx.clip(static_cast<IntRect>(event->area));
>+        frame->page()->inspectorController()->drawNodeHighlight(ctx);
>+        ctx.restore();
>     }

As discussed on jabber, the save/restore stuff is probably not needed.

> 
>     return FALSE;
>-- 
>1.7.1
>

[Gustavo Noronha (kov)]

Comment on attachment 63341 [details]
proposed patch

Landed as r64567.