Bug 43418 - [GTK] Extra check needed at AccessibilityObject::visiblePositionRangeForRange
Summary: [GTK] Extra check needed at AccessibilityObject::visiblePositionRangeForRange
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-08-03 06:19 PDT by Mario Sanchez Prada
Modified: 2010-08-05 00:56 PDT (History)
2 users (show)

See Also:

Patch proposal (3.14 KB, patch)
2010-08-03 06:50 PDT, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2010-08-03 06:19:46 PDT
It would be needed to make some extra checks at AccessibilityObject::visiblePositionRangeForRange to make sure toRenderText() function is called with valid parameters, that is, a RenderObject returning 'true when calling to its isText() method.

This check is needed because current code doesn't do it and could be executed with RenderObjects other than instances of the RenderText subclass, resulting in failures such as the one in the following stack trace:


I'm now building WK with a patch for this. Will attach it as soon as I tested it.
Comment 1 Mario Sanchez Prada 2010-08-03 06:46:16 PDT
Adding Xan to CC
Comment 2 Mario Sanchez Prada 2010-08-03 06:50:28 PDT
Created attachment 63331 [details]
Patch proposal

This patch just adds the needed checks that should have been added before, along with fix for bug 25677 (my fault)
Comment 3 Xan Lopez 2010-08-03 07:09:27 PDT
Comment on attachment 63331 [details]
Patch proposal

Comment 4 WebKit Commit Bot 2010-08-05 00:55:55 PDT
Comment on attachment 63331 [details]
Patch proposal

Clearing flags on attachment: 63331

Committed r64721: <http://trac.webkit.org/changeset/64721>
Comment 5 WebKit Commit Bot 2010-08-05 00:56:00 PDT
All reviewed patches have been landed.  Closing bug.