Bug 43411 - The ARM JIT does not support JSValue32_64 with RVCT
Summary: The ARM JIT does not support JSValue32_64 with RVCT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Critical
Assignee: Gabor Loki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-03 04:39 PDT by Gabor Loki
Modified: 2010-08-05 23:31 PDT (History)
3 users (show)

See Also:


Attachments
JSValue32_64 is enabled for RVCT by default (6.33 KB, patch)
2010-08-05 08:01 PDT, Gabor Loki
barraclough: review+
loki: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-08-03 04:39:27 PDT
There are some missing functions and codes in the JSValue32_64 section for RVCT.
I am going to implement those.
Comment 1 Gabor Loki 2010-08-05 08:01:28 PDT
Created attachment 63593 [details]
JSValue32_64 is enabled for RVCT by default

RVCT 4.0 is happy with this patch.

Here is the result of the comparison of JSValue32 and -32_64 on ARM with RVCT 4.0.
  SunSpider: JSValue32_64 is 1.835x as fast
  V8: JSValue32_64 is 1.06x as slow
  WindScorpion: JSValue32_64 is 1.01x as slow
Comment 2 WebKit Review Bot 2010-08-05 08:02:23 PDT
Attachment 63593 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:242:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:460:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gabor Loki 2010-08-05 22:51:13 PDT
Committed revision 64818.