Bug 43381 - re-enable WebGL on Leopard for now
Summary: re-enable WebGL on Leopard for now
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
Depends on: 42118
  Show dependency treegraph
Reported: 2010-08-02 14:25 PDT by Zhenyao Mo
Modified: 2010-08-04 16:03 PDT (History)
5 users (show)

See Also:

patch (4.83 KB, patch)
2010-08-02 14:31 PDT, Zhenyao Mo
levin: review-
zmo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-08-02 14:25:50 PDT
Per discussion on https://bugs.webkit.org/show_bug.cgi?id=42118, whether a Leopard is capable of running WebGL depends on the GL extensions it supports.  Therefore, re-enable WebGL on Leopard for now.  (My Mac is a Leopard, so disabling WebGL on Leopard is blocking my progress.)
Comment 1 Zhenyao Mo 2010-08-02 14:31:26 PDT
Created attachment 63262 [details]

This patch reverses the changes made in http://trac.webkit.org/changeset/63688.  Let's do this for now until Chris Marrin's more complicated logic is in.
Comment 2 Kenneth Russell 2010-08-02 14:53:31 PDT
This issue is making it difficult for Mo to develop, and since he's been doing a great deal of WebGL work and bug fixing recently I would like to address it now. The patch looks okay to me.

CC'ing Sam Weinig in case checking this in is going to break one of the bots right now (I believe that test cases failing while bringing up a new bot was the motivation behind https://bugs.webkit.org/show_bug.cgi?id=42118 ). A quick targeted patch for that issue would be to disable WebGL at run time if the graphics card on Mac OS X is a GeForce 7300 (or 7000 series more generally).
Comment 3 David Levin 2010-08-02 15:31:39 PDT
Comment on attachment 63262 [details]

From cmarrin:"I need to complete the implementation for https://bugs.webkit.org/show_bug.cgi?id=42118 or this will break the build bots."
Comment 4 Zhenyao Mo 2010-08-02 15:44:32 PDT
OK, I am upgrading my machine to Snow Leopard.  Good luck to others who's still using Leopard!