RESOLVED INVALID 43381
re-enable WebGL on Leopard for now 
https://bugs.webkit.org/show_bug.cgi?id=43381
Summary re-enable WebGL on Leopard for now
Zhenyao Mo
Reported 2010-08-02 14:25:50 PDT
Per discussion on https://bugs.webkit.org/show_bug.cgi?id=42118, whether a Leopard is capable of running WebGL depends on the GL extensions it supports. Therefore, re-enable WebGL on Leopard for now. (My Mac is a Leopard, so disabling WebGL on Leopard is blocking my progress.)
Attachments
patch (4.83 KB, patch)
2010-08-02 14:31 PDT, Zhenyao Mo 		levin: review-
zmo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-08-02 14:31:26 PDT
Created attachment 63262 [details] patch This patch reverses the changes made in http://trac.webkit.org/changeset/63688. Let's do this for now until Chris Marrin's more complicated logic is in.
Kenneth Russell
Comment 2 2010-08-02 14:53:31 PDT
This issue is making it difficult for Mo to develop, and since he's been doing a great deal of WebGL work and bug fixing recently I would like to address it now. The patch looks okay to me. CC'ing Sam Weinig in case checking this in is going to break one of the bots right now (I believe that test cases failing while bringing up a new bot was the motivation behind https://bugs.webkit.org/show_bug.cgi?id=42118 ). A quick targeted patch for that issue would be to disable WebGL at run time if the graphics card on Mac OS X is a GeForce 7300 (or 7000 series more generally).
David Levin
Comment 3 2010-08-02 15:31:39 PDT
Comment on attachment 63262 [details] patch From cmarrin:"I need to complete the implementation for https://bugs.webkit.org/show_bug.cgi?id=42118 or this will break the build bots."
Zhenyao Mo
Comment 4 2010-08-02 15:44:32 PDT
OK, I am upgrading my machine to Snow Leopard. Good luck to others who's still using Leopard!
Note You need to log in before you can comment on or make changes to this bug.