Bug 43352 - Initiate speech input requests on click event
Summary: Initiate speech input requests on click event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39485
  Show dependency tree / graph
 
Reported: 2010-08-02 08:35 PDT by Satish Sampath
Modified: 2010-08-03 04:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2010-08-02 08:41 PDT, Satish Sampath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2010-08-02 08:35:01 PDT 
Instead of initiating speech input requests on mouseup, do it on click event similar to how some other elements do (for e.g. spin button). This introduces no change in functionality from a user perspective while allowing clean automation for test purposes.
Comment 1 Satish Sampath 2010-08-02 08:41:37 PDT 
Created attachment 63221 [details]
Patch
Comment 2 Kent Tamura 2010-08-02 16:48:23 PDT 
Comment on attachment 63221 [details]
Patch

ok
Comment 3 Kent Tamura 2010-08-03 03:10:17 PDT 
Comment on attachment 63221 [details]
Patch

I'll commit this.
Comment 4 Kent Tamura 2010-08-03 03:12:47 PDT 
Comment on attachment 63221 [details]
Patch

Clearing flags on attachment: 63221

Committed r64542: <http://trac.webkit.org/changeset/64542>
Comment 5 Kent Tamura 2010-08-03 03:12:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-08-03 04:52:12 PDT 
http://trac.webkit.org/changeset/64542 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/64541
http://trac.webkit.org/changeset/64542
http://trac.webkit.org/changeset/64543