Bug 43350 - warning: integer overflow in expression - JITPropertyAccess32_64.cpp
Summary: warning: integer overflow in expression - JITPropertyAccess32_64.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 43191
  Show dependency tree / graph
 
Reported: 2010-08-02 08:16 PDT by Csaba Osztrogonác
Modified: 2010-08-10 08:09 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-08-02 08:16:45 PDT 
http://trac.webkit.org/changeset/64320 caused the following warnings on the Qt Linux bot:

../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp: In member function ‘void JSC::JIT::emit_op_put_by_val(JSC::Instruction*)’:
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:378: warning: integer overflow in expression
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:379: warning: integer overflow in expression
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:382: warning: integer overflow in expression
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp: In member function ‘void JSC::JIT::privateCompilePatchGetArrayLength(JSC::ReturnAddressPtr)’:
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:735: warning: integer overflow in expression

We should fix it to treat warnings as errors by default.
Comment 1 Gabor Loki 2010-08-10 08:09:28 PDT 
Fixed (probably in r64937).