Bug 43338 - Compile fix for android, missing guards in SVGResourcesCycleSolver.cpp
Summary: Compile fix for android, missing guards in SVGResourcesCycleSolver.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-02 05:17 PDT by Kristian Monsen
Modified: 2010-08-02 09:18 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch. (1.27 KB, patch)
2010-08-02 05:22 PDT, Kristian Monsen 		steveblock: review-
Details | Formatted Diff | Diff
Proposed patch (Updated Changelog description). (1.36 KB, patch)
2010-08-02 05:51 PDT, Kristian Monsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Monsen 2010-08-02 05:17:10 PDT 
Android does not have FILTERS enabled and does not compile without this fix.
Comment 1 Kristian Monsen 2010-08-02 05:22:35 PDT 
Created attachment 63193 [details]
Proposed patch.
Comment 2 Steve Block 2010-08-02 05:27:55 PDT 
Comment on attachment 63193 [details]
Proposed patch.

Code looks fine, but this can't be landed with an OOPS in the tests line. Just say this is a build fix only.

Also, it would be good to link to the change that added this from the bug.
Comment 3 Kristian Monsen 2010-08-02 05:51:58 PDT 
Created attachment 63204 [details]
Proposed patch (Updated Changelog description).
Comment 4 Steve Block 2010-08-02 05:58:34 PDT 
Comment on attachment 63204 [details]
Proposed patch (Updated Changelog description).

r=me
Comment 5 WebKit Commit Bot 2010-08-02 09:18:06 PDT 
Comment on attachment 63204 [details]
Proposed patch (Updated Changelog description).

Clearing flags on attachment: 63204

Committed r64465: <http://trac.webkit.org/changeset/64465>
Comment 6 WebKit Commit Bot 2010-08-02 09:18:10 PDT 
All reviewed patches have been landed.  Closing bug.