Bug 43322 - [EFL] REGRESSION(64425) need to fix build break
Summary: [EFL] REGRESSION(64425) need to fix build break
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-01 17:55 PDT by Ryuan Choi
Modified: 2010-08-03 08:47 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.09 KB, patch)
2010-08-01 18:01 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (1.08 KB, patch)
2010-08-01 21:25 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (1.03 KB, patch)
2010-08-01 21:37 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2010-08-01 17:55:24 PDT 
I got an error like below

/workspace/WebKit/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:52:26: fatal error: PopupMenuEfl.h: No such file or directory
compilation terminated.
make[2]: *** [WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/ChromeClientEfl.cpp.o] 오류 1
make[2]: *** 끝나지 않은 작업을 기다리고 있습니다....
make[1]: *** [WebKit/CMakeFiles/ewebkit.dir/all] 오류 2
make: *** [all] 오류 2
Comment 1 Ryuan Choi 2010-08-01 18:01:52 PDT 
Created attachment 63177 [details]
Patch
Comment 2 Patrick R. Gansterer 2010-08-01 20:52:39 PDT 
Please add it into the WebKit/efl/CMakeListsEfl.txt instead of the CMakeLists.txt.
CMakeLists.txt is only for platform-independet stuff
Comment 3 Ryuan Choi 2010-08-01 21:19:53 PDT 
(In reply to comment #2)
> Please add it into the WebKit/efl/CMakeListsEfl.txt instead of the CMakeLists.txt.
> CMakeLists.txt is only for platform-independet stuff

Thank you for your advice.

I'll create WebKit/CMakeListsEfl.txt
Comment 4 Ryuan Choi 2010-08-01 21:25:14 PDT 
Created attachment 63179 [details]
Patch
Comment 5 Ryuan Choi 2010-08-01 21:37:29 PDT 
Created attachment 63180 [details]
Patch
Comment 6 Leandro Pereira 2010-08-03 08:47:25 PDT 
Comment on attachment 63180 [details]
Patch

Clearing flags on attachment: 63180

Committed r64559: <http://trac.webkit.org/changeset/64559>
Comment 7 Leandro Pereira 2010-08-03 08:47:34 PDT 
All reviewed patches have been landed.  Closing bug.