Bug 43296 - fast/text/hyphen* tests have different results on Leopard
Summary: fast/text/hyphen* tests have different results on Leopard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-31 03:42 PDT by Nikolas Zimmermann
Modified: 2010-11-13 20:36 PST (History)
2 users (show)

See Also:


Attachments
Look up the value of the AppleLanguages default through the normal NSUserDefaults search order (2.28 KB, patch)
2010-11-13 19:29 PST, mitz
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-07-31 03:42:45 PDT
I'm going to rebaseline these tests to stop the bots from failing. Someone should look into, wheter these results are correct or not.
Comment 1 Nikolas Zimmermann 2010-07-31 03:53:21 PDT
Erm, I meant I'm going to skip them.
Comment 2 Nikolas Zimmermann 2010-08-06 04:40:00 PDT
Also affects fast/text/hyphens-locale.html. Skipping to turn leopard green again.
Dan, can you have a look?
Comment 3 mitz 2010-08-06 07:12:11 PDT
Like I mentioned in another bug, I think this is a result of the AppleLanguages user default not being set to (en) on the machine running the tests.
Comment 4 Nikolas Zimmermann 2010-08-06 07:21:56 PDT
(In reply to comment #3)
> Like I mentioned in another bug, I think this is a result of the AppleLanguages user default not being set to (en) on the machine running the tests.

Really? I thought the bots run al in language=en?
Comment 5 mitz 2010-08-06 07:23:43 PDT
See bug 41093.
Comment 6 mitz 2010-08-18 23:00:09 PDT
Partially addressed in <http://trac.webkit.org/projects/webkit/changeset/65652>. fast/text/hyphens-locale.html tests the default hyphenation locale and therefore still depends on user defaults. This can probably be addressed by changing WebCore to read from the application domain instead of the global domain.
Comment 7 mitz 2010-11-13 19:29:04 PST
Created attachment 73838 [details]
Look up the value of the AppleLanguages default through the normal NSUserDefaults search order
Comment 8 Dave Hyatt 2010-11-13 20:03:07 PST
Comment on attachment 73838 [details]
Look up the value of the AppleLanguages default through the normal NSUserDefaults search order

r=me
Comment 9 mitz 2010-11-13 20:36:41 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/71977>.