RESOLVED FIXED 43296
fast/text/hyphen* tests have different results on Leopard 
https://bugs.webkit.org/show_bug.cgi?id=43296
Summary fast/text/hyphen* tests have different results on Leopard
Nikolas Zimmermann
Reported 2010-07-31 03:42:45 PDT
I'm going to rebaseline these tests to stop the bots from failing. Someone should look into, wheter these results are correct or not.
Attachments
Look up the value of the AppleLanguages default through the normal NSUserDefaults search order (2.28 KB, patch)
2010-11-13 19:29 PST, mitz 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-07-31 03:53:21 PDT
Erm, I meant I'm going to skip them.
Nikolas Zimmermann
Comment 2 2010-08-06 04:40:00 PDT
Also affects fast/text/hyphens-locale.html. Skipping to turn leopard green again. Dan, can you have a look?
mitz
Comment 3 2010-08-06 07:12:11 PDT
Like I mentioned in another bug, I think this is a result of the AppleLanguages user default not being set to (en) on the machine running the tests.
Nikolas Zimmermann
Comment 4 2010-08-06 07:21:56 PDT
(In reply to comment #3) > Like I mentioned in another bug, I think this is a result of the AppleLanguages user default not being set to (en) on the machine running the tests. Really? I thought the bots run al in language=en?
mitz
Comment 5 2010-08-06 07:23:43 PDT
See bug 41093.
mitz
Comment 6 2010-08-18 23:00:09 PDT
Partially addressed in <http://trac.webkit.org/projects/webkit/changeset/65652>. fast/text/hyphens-locale.html tests the default hyphenation locale and therefore still depends on user defaults. This can probably be addressed by changing WebCore to read from the application domain instead of the global domain.
mitz
Comment 7 2010-11-13 19:29:04 PST
Created attachment 73838 [details] Look up the value of the AppleLanguages default through the normal NSUserDefaults search order
Dave Hyatt
Comment 8 2010-11-13 20:03:07 PST
Comment on attachment 73838 [details] Look up the value of the AppleLanguages default through the normal NSUserDefaults search order r=me
mitz
Comment 9 2010-11-13 20:36:41 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/71977>.
Note You need to log in before you can comment on or make changes to this bug.