Bug 43288 - Add an NPObject class template helper to TestNetscapePlugin
Summary: Add an NPObject class template helper to TestNetscapePlugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 16:54 PDT by Anders Carlsson
Modified: 2010-08-01 12:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.28 KB, patch)
2010-07-30 16:59 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (9.36 KB, patch)
2010-07-30 17:10 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-30 16:54:50 PDT 
Add an NPObject class template helper to TestNetscapePlugin
Comment 1 Anders Carlsson 2010-07-30 16:59:30 PDT 
Created attachment 63127 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-30 17:00:47 PDT 
Attachment 63127 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:140:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2010-07-30 17:05:47 PDT 
Attachment 63127 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3618299
Comment 4 Anders Carlsson 2010-07-30 17:10:01 PDT 
Created attachment 63128 [details]
Patch
Comment 5 WebKit Review Bot 2010-07-30 17:13:40 PDT 
Attachment 63128 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:39:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:141:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2010-08-01 12:40:12 PDT 
Committed r64443: <http://trac.webkit.org/changeset/64443>