Test fast/media/view-mode-media-feature.html is skipped because LayoutTestController lacks method setViewModeMediaFeature().
Created attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it
Attachment 64775 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/gtk/webkit/webkitwebview.h:68: This { should be at the end of the previous line [whitespace/braces] [4] WebKit/gtk/webkit/webkitwebview.h:352: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:356: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it Looks good!
Comment on attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it Thanks, Kenneth! I'll switch the review flag to ? just to get the EWS bots to try the patch for me since they seem to not build patches after they get r+ =(
Fine :-) history records the r+
(In reply to comment #2) > Attachment 64775 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 > WebKit/gtk/webkit/webkitwebview.h:68: This { should be at the end of the previous line [whitespace/braces] [4] > WebKit/gtk/webkit/webkitwebview.h:352: Extra space before ( in function call [whitespace/parens] [4] > WebKit/gtk/webkit/webkitwebview.h:356: Extra space before ( in function call [whitespace/parens] [4] > Total errors found: 3 in 12 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. FWIW, these are false positives. I thought out API headers were already special-cased, but it looks like they still need to be =)
Comment on attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it Removing flag, I'll land this with kenne's r+ as soon as I finish my final build test here.
Landed as r65666.
(In reply to comment #8) > Landed as r65666. The 65th commit of the devil, or something.