Bug 43278 - [Gtk] Enable view mode media feature layout test
Summary: [Gtk] Enable view mode media feature layout test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 16:13 PDT by Luiz Agostini
Modified: 2010-08-19 06:33 PDT (History)
6 users (show)

See Also:


Attachments
Add API to support the feature, and the testing infrastructure to test it (18.00 KB, patch)
2010-08-18 14:42 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-07-30 16:13:52 PDT
Test fast/media/view-mode-media-feature.html is skipped because LayoutTestController lacks method setViewModeMediaFeature().
Comment 1 Gustavo Noronha (kov) 2010-08-18 14:42:43 PDT
Created attachment 64775 [details]
Add API to support the feature, and the testing infrastructure to test it
Comment 2 WebKit Review Bot 2010-08-18 14:43:44 PDT
Attachment 64775 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/gtk/webkit/webkitwebview.h:68:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKit/gtk/webkit/webkitwebview.h:352:  Extra space before ( in function call  [whitespace/parens] [4]
WebKit/gtk/webkit/webkitwebview.h:356:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kenneth Rohde Christiansen 2010-08-18 14:44:54 PDT
Comment on attachment 64775 [details]
Add API to support the feature, and the testing infrastructure to test it

Looks good!
Comment 4 Gustavo Noronha (kov) 2010-08-18 14:51:45 PDT
Comment on attachment 64775 [details]
Add API to support the feature, and the testing infrastructure to test it

Thanks, Kenneth! I'll switch the review flag to ? just to get the EWS bots to try the patch for me since they seem to not build patches after they get r+ =(
Comment 5 Kenneth Rohde Christiansen 2010-08-18 14:52:41 PDT
Fine :-) history records the r+
Comment 6 Gustavo Noronha (kov) 2010-08-19 06:18:29 PDT
(In reply to comment #2)
> Attachment 64775 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> WebKit/gtk/webkit/webkitwebview.h:68:  This { should be at the end of the previous line  [whitespace/braces] [4]
> WebKit/gtk/webkit/webkitwebview.h:352:  Extra space before ( in function call  [whitespace/parens] [4]
> WebKit/gtk/webkit/webkitwebview.h:356:  Extra space before ( in function call  [whitespace/parens] [4]
> Total errors found: 3 in 12 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

FWIW, these are false positives. I thought out API headers were already special-cased, but it looks like they still need to be =)
Comment 7 Gustavo Noronha (kov) 2010-08-19 06:19:09 PDT
Comment on attachment 64775 [details]
Add API to support the feature, and the testing infrastructure to test it

Removing flag, I'll land this with kenne's r+ as soon as I finish my final build test here.
Comment 8 Gustavo Noronha (kov) 2010-08-19 06:32:50 PDT
Landed as r65666.
Comment 9 Gustavo Noronha (kov) 2010-08-19 06:33:33 PDT
(In reply to comment #8)
> Landed as r65666.

The 65th commit of the devil, or something.