Bug 43274 - Add first pass of structured message passing
Summary: Add first pass of structured message passing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 15:12 PDT by Sam Weinig
Modified: 2010-07-30 15:28 PDT (History)
1 user (show)

See Also:


Attachments
Patch (32.94 KB, patch)
2010-07-30 15:14 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-30 15:12:42 PDT
Add first pass of structured message passing. Just UIProcess to InjectedBundle this time.
Comment 1 Sam Weinig 2010-07-30 15:14:04 PDT
Created attachment 63110 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-30 15:16:46 PDT
Attachment 63110 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:118:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:167:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundle.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/UIProcess/WebContext.cpp:189:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/UIProcess/WebContext.cpp:191:  One space before end of line comments  [whitespace/comments] [5]
WebKit2/UIProcess/WebContext.cpp:192:  One space before end of line comments  [whitespace/comments] [5]
WebKit2/UIProcess/WebContext.cpp:194:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 7 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-07-30 15:28:19 PDT
Landed in 64380.