Bug 43268 - Implement NPN_Evaluate
Summary: Implement NPN_Evaluate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 13:35 PDT by Anders Carlsson
Modified: 2010-07-30 14:44 PDT (History)
0 users

See Also:

Attachments
Patch (13.88 KB, patch)
2010-07-30 13:43 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-30 13:35:06 PDT 
Implement NPN_Evaluate
Comment 1 Anders Carlsson 2010-07-30 13:43:42 PDT 
Created attachment 63098 [details]
Patch
Comment 2 Sam Weinig 2010-07-30 14:36:38 PDT 
Comment on attachment 63098 [details]
Patch


> +    bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result);

& on the wrong side.

> +
>      void setStatusbarText(const WebCore::String&);
> +    bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result);

Here too.


> +    // Evaluates the given script string in the context of the given NPObject.
> +    virtual bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result, bool allowPopups) = 0;
> +

And here too.


>  
> +bool PluginView::evaluate(NPObject* npObject, const String &scriptString, NPVariant* result, bool allowPopups)
> +{

And again.

> +    virtual bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result, bool allowPopups);
Once more!

r=me
Comment 3 Anders Carlsson 2010-07-30 14:44:24 PDT 
Committed r64377: <http://trac.webkit.org/changeset/64377>