Web Inspector: inspector tests should be frontend-driven
Created attachment 63088 [details] Proposed patch.
Created attachment 63147 [details] Define inspector layout test as a sequence of steps.
Comment on attachment 63088 [details] Proposed patch. LayoutTests/http/tests/inspector/inspector-test2.js:162 + "if (!InspectorTest) {", !window.InspectorTest, otherwise you'll get an exception. LayoutTests/http/tests/inspector/inspector-test2.js:174 + layoutTestController.evaluateInWebInspector(completeTestCallId, "true"); This roundtrip shouldn't be needed(at least at the new tests). LayoutTests/http/tests/inspector/inspector-test2.js:69 + function createKeyEvent(keyIdentifier) Let's move all these methods on to InspectorTest object so that it's easy to distinguish test methods from the rest of front-end methods. LayoutTests/http/tests/inspector/inspector-test2.js:24 + InspectorTest.push = function(text) maybe rename it to addResult?
Created attachment 64594 [details] Proposed patch.
(In reply to comment #3) > (From update of attachment 63088 [details]) > LayoutTests/http/tests/inspector/inspector-test2.js:162 > + "if (!InspectorTest) {", > !window.InspectorTest, otherwise you'll get an exception. done > LayoutTests/http/tests/inspector/inspector-test2.js:174 > + layoutTestController.evaluateInWebInspector(completeTestCallId, "true"); > This roundtrip shouldn't be needed(at least at the new tests). done > LayoutTests/http/tests/inspector/inspector-test2.js:69 > + function createKeyEvent(keyIdentifier) > Let's move all these methods on to InspectorTest object so that it's easy to distinguish test methods from the rest of front-end methods. This methods are actually private methods of InspectorTest not visible from outside. We can make them public if needed by tests. > > LayoutTests/http/tests/inspector/inspector-test2.js:24 > + InspectorTest.push = function(text) > maybe rename it to addResult? done
Created attachment 64693 [details] Proposed patch.
Comment on attachment 64693 [details] Proposed patch. Clearing flags on attachment: 64693 Committed r65606: <http://trac.webkit.org/changeset/65606>
All reviewed patches have been landed. Closing bug.