Bug 43262 - style errors in Navigator.h
Summary: style errors in Navigator.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 10:11 PDT by chris fleizach
Modified: 2010-07-30 14:14 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2010-07-30 10:16 PDT, chris fleizach
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-07-30 10:11:25 PDT
I want to modify Navigator.h but there are style errors. i'd like to resolve the style errors so my commit won't have them

the style error is bad class identation
Comment 1 chris fleizach 2010-07-30 10:16:22 PDT
Created attachment 63073 [details]
Patch
Comment 2 Darin Adler 2010-07-30 12:31:08 PDT
Comment on attachment 63073 [details]
Patch

Seems fine to chagne the indentation.

> +    ~Navigator();

This should be explicitly marked virtual. We prefer to do that explicitly even when we derive from a class where the destructor is already virtual.
Comment 3 chris fleizach 2010-07-30 14:14:25 PDT
http://trac.webkit.org/changeset/64371