WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 43262
style errors in Navigator.h
https://bugs.webkit.org/show_bug.cgi?id=43262
Summary
style errors in Navigator.h
chris fleizach
Reported
2010-07-30 10:11:25 PDT
I want to modify Navigator.h but there are style errors. i'd like to resolve the style errors so my commit won't have them the style error is bad class identation
Attachments
Patch
(3.17 KB, patch)
2010-07-30 10:16 PDT
,
chris fleizach
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
chris fleizach
Comment 1
2010-07-30 10:16:22 PDT
Created
attachment 63073
[details]
Patch
Darin Adler
Comment 2
2010-07-30 12:31:08 PDT
Comment on
attachment 63073
[details]
Patch Seems fine to chagne the indentation.
> + ~Navigator();
This should be explicitly marked virtual. We prefer to do that explicitly even when we derive from a class where the destructor is already virtual.
chris fleizach
Comment 3
2010-07-30 14:14:25 PDT
http://trac.webkit.org/changeset/64371
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug