Bug 43261 – Move speech input layout tests to their own directory.

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Satish Sampath]

This will help with future patches where more layout tests are coming in for speech input.

[Satish Sampath]

Created attachment 63072 [details]
Patch

[Jeremy Orlow]

Comment on attachment 63072 [details]
Patch

LayoutTests/platform/chromium/drt_expectations.txt:12
 +  BUG_DRT WIN LINUX : fast/speech/input-appearance-speechbutton.html = IMAGE+TEXT
get rid of MAC/WIN/LINUX and then combine the duplicate lines.

r=me

[Satish Sampath]

Created attachment 63090 [details]
Patch

Addressed Jeremy's comments.

[David Levin]

Comment on attachment 63090 [details]
Patch


> diff --git a/LayoutTests/platform/chromium/drt_expectations.txt b/LayoutTests/platform/chromium/drt_expectations.txt
> index 735144ed754c4a48a0fe0bf9b796d68c459af9ad..cbf15ae99b529f2b11064d1d78fe1dd5d7516b9d 100644
> --- a/LayoutTests/platform/chromium/drt_expectations.txt
> +++ b/LayoutTests/platform/chromium/drt_expectations.txt
> @@ -6,10 +6,8 @@
>  BUG_DRT : fast/backgrounds/animated-gif-as-background.html = IMAGE
>  
>  // Missing image resource
> -BUG_DRT MAC : fast/forms/input-appearance-searchandspeech.html = IMAGE
> -BUG_DRT MAC : fast/forms/input-appearance-speechbutton.html = IMAGE
> -BUG_DRT WIN LINUX : fast/forms/input-appearance-searchandspeech.html = IMAGE+TEXT
> -BUG_DRT WIN LINUX : fast/forms/input-appearance-speechbutton.html = IMAGE+TEXT
> +BUG_DRT : fast/speech/input-appearance-searchandspeech.html = IMAGE+TEXT
> +BUG_DRT : fast/speech/input-appearance-speechbutton.html = IMAGE+TEXT

I don't think this change is quite right.

It should be 

BUG_DRT : fast/speech/input-appearance-searchandspeech.html = IMAGE IMAGE+TEXT
BUG_DRT : fast/speech/input-appearance-speechbutton.html = IMAGE IMAGE+TEXT

but even then we will be listing failures for MAC, WIN, and LINUX that don't occur on those platforms.

This would mean that the flakiness dashboard (http://test-results.appspot.com/dashboards/flakiness_dashboard.html) would show that there are extra modifiers for those platforms (IMAGE in WIN LINUX and IMAGE+TEXT for MAC). This just leads to more noise in interpreting what is going on and possible clean-up tasks for others as they may try to remove these extra modifiers.

Lastly, it would hide if the test actually started failing differently on those platforms (IMAGE+TEXT on MAC for instance), and this is part of the point of modifiers as I understand it.


So I approved the previous patch which didn't have this issue.

[WebKit Commit Bot]

Comment on attachment 63072 [details]
Patch

Clearing flags on attachment: 63072

Committed r64375: <http://trac.webkit.org/changeset/64375>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/64388 might have broken Chromium Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/64385
http://trac.webkit.org/changeset/64386
http://trac.webkit.org/changeset/64387
http://trac.webkit.org/changeset/64388

[Andrew Wilson]

Reverted r64375 because it was breaking chromium downstream. I think there are some expectations files that need to be moved also.

[Satish Sampath]

The revert was rolled back in http://trac.webkit.org/changeset/64424, and the tests which were failing have been temporarily disabled for chromium in http://trac.webkit.org/changeset/64431 (they have been disabled for all other platforms already since the feature was not in working condition, this just brings it on par with the rest). I'll open a new bug and review once the tests are ready to be enabled.