Bug 43261 - Move speech input layout tests to their own directory.
Summary: Move speech input layout tests to their own directory.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on: 43285
Blocks: 39485
  Show dependency treegraph
Reported: 2010-07-30 10:08 PDT by Satish Sampath
Modified: 2010-08-02 07:05 PDT (History)
7 users (show)

See Also:

Patch (8.14 KB, patch)
2010-07-30 10:15 PDT, Satish Sampath
no flags Details | Formatted Diff | Diff
Patch (7.98 KB, patch)
2010-07-30 11:39 PDT, Satish Sampath
levin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2010-07-30 10:08:55 PDT
This will help with future patches where more layout tests are coming in for speech input.
Comment 1 Satish Sampath 2010-07-30 10:15:49 PDT
Created attachment 63072 [details]
Comment 2 Jeremy Orlow 2010-07-30 11:05:27 PDT
Comment on attachment 63072 [details]

 +  BUG_DRT WIN LINUX : fast/speech/input-appearance-speechbutton.html = IMAGE+TEXT
get rid of MAC/WIN/LINUX and then combine the duplicate lines.

Comment 3 Satish Sampath 2010-07-30 11:39:19 PDT
Created attachment 63090 [details]

Addressed Jeremy's comments.
Comment 4 David Levin 2010-07-30 14:20:00 PDT
Comment on attachment 63090 [details]

> diff --git a/LayoutTests/platform/chromium/drt_expectations.txt b/LayoutTests/platform/chromium/drt_expectations.txt
> index 735144ed754c4a48a0fe0bf9b796d68c459af9ad..cbf15ae99b529f2b11064d1d78fe1dd5d7516b9d 100644
> --- a/LayoutTests/platform/chromium/drt_expectations.txt
> +++ b/LayoutTests/platform/chromium/drt_expectations.txt
> @@ -6,10 +6,8 @@
>  BUG_DRT : fast/backgrounds/animated-gif-as-background.html = IMAGE
>  // Missing image resource
> -BUG_DRT MAC : fast/forms/input-appearance-searchandspeech.html = IMAGE
> -BUG_DRT MAC : fast/forms/input-appearance-speechbutton.html = IMAGE
> -BUG_DRT WIN LINUX : fast/forms/input-appearance-searchandspeech.html = IMAGE+TEXT
> -BUG_DRT WIN LINUX : fast/forms/input-appearance-speechbutton.html = IMAGE+TEXT
> +BUG_DRT : fast/speech/input-appearance-searchandspeech.html = IMAGE+TEXT
> +BUG_DRT : fast/speech/input-appearance-speechbutton.html = IMAGE+TEXT

I don't think this change is quite right.

It should be 

BUG_DRT : fast/speech/input-appearance-searchandspeech.html = IMAGE IMAGE+TEXT
BUG_DRT : fast/speech/input-appearance-speechbutton.html = IMAGE IMAGE+TEXT

but even then we will be listing failures for MAC, WIN, and LINUX that don't occur on those platforms.

This would mean that the flakiness dashboard (http://test-results.appspot.com/dashboards/flakiness_dashboard.html) would show that there are extra modifiers for those platforms (IMAGE in WIN LINUX and IMAGE+TEXT for MAC). This just leads to more noise in interpreting what is going on and possible clean-up tasks for others as they may try to remove these extra modifiers.

Lastly, it would hide if the test actually started failing differently on those platforms (IMAGE+TEXT on MAC for instance), and this is part of the point of modifiers as I understand it.

So I approved the previous patch which didn't have this issue.
Comment 5 WebKit Commit Bot 2010-07-30 14:29:48 PDT
Comment on attachment 63072 [details]

Clearing flags on attachment: 63072

Committed r64375: <http://trac.webkit.org/changeset/64375>
Comment 6 WebKit Commit Bot 2010-07-30 14:29:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-07-30 17:08:03 PDT
http://trac.webkit.org/changeset/64388 might have broken Chromium Linux Release
The following changes are on the blame list:
Comment 8 Andrew Wilson 2010-07-30 17:24:18 PDT
Reverted r64375 because it was breaking chromium downstream. I think there are some expectations files that need to be moved also.
Comment 9 Satish Sampath 2010-08-02 07:05:46 PDT
The revert was rolled back in http://trac.webkit.org/changeset/64424, and the tests which were failing have been temporarily disabled for chromium in http://trac.webkit.org/changeset/64431 (they have been disabled for all other platforms already since the feature was not in working condition, this just brings it on par with the rest). I'll open a new bug and review once the tests are ready to be enabled.