Bug 43254 – Expand SVG Attribute Macros

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Fady Samuel]

SVG Attributes are currently macros. This often makes debugging SVG a nightmare as we can't trace through macros.

[Fady Samuel]

Created attachment 63065 [details]
SVG Attribute macros expanded

[Dimitri Glazkov (Google)]

Comment on attachment 63065 [details]
SVG Attribute macros expanded

It's missing a ChangeLog. Otherwise, looks good.

[Fady Samuel]

Created attachment 63067 [details]
SVG Attribute Macros Expanded

[Dimitri Glazkov (Google)]

Comment on attachment 63067 [details]
SVG Attribute Macros Expanded

I'll pick on you, but only because you're new here! :P

WebCore/ChangeLog:10
 +          No new tests.
Why no new test?

Usually a simple explanation is provided, like:

"No change in behavior, so no new tests."

WebCore/ChangeLog:130
 +          * rendering/style/SVGRenderStyleDefs.h:
This long list of changes is not very useful. Typically, the author of the ChangeLog takes this produced template and makes something useful out of it, like:

rendering/style/SVGRenderStyle.h: Expanded and removed references to <list of macros> macros.
rendering/style/SVGRenderStyleDefs.h: Removed definitons for expanded macros.

Then you can zap the rest of the list in the template.

[Fady Samuel]

Created attachment 63076 [details]
SVG Attribute Macros Expanded

Made the change log nicer. Thanks dglazkov for your patience with my n00bness at writing useful changelogs.:)

[Dimitri Glazkov (Google)]

Comment on attachment 63076 [details]
SVG Attribute Macros Expanded

ok.

[Nikolas Zimmermann]

Thanks Fady, good start at cleaning up SVGRenderStyle & friends.

[WebKit Commit Bot]

Comment on attachment 63076 [details]
SVG Attribute Macros Expanded

Clearing flags on attachment: 63076

Committed r64367: <http://trac.webkit.org/changeset/64367>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Comment on attachment 63076 [details]
SVG Attribute Macros Expanded

WebCore/ChangeLog:1
 +  2010-07-30  [e-mail]  <[e-mail]>
This should be your Full Name <email>, no email twice. :)

WebCore/rendering/style/SVGRenderStyle.h: 
 +      SVG_RS_DEFINE_ATTRIBUTE(EAlignmentBaseline, AlignmentBaseline, alignmentBaseline, AB_AUTO)
I'm not sure why expanding these is better... but OK.

[Fady Samuel]

(In reply to comment #10)
> (From update of attachment 63076 [details])
> WebCore/ChangeLog:1
>  +  2010-07-30  [e-mail]  <[e-mail]>
> This should be your Full Name <email>, no email twice. :)
> 
> WebCore/rendering/style/SVGRenderStyle.h: 
>  +      SVG_RS_DEFINE_ATTRIBUTE(EAlignmentBaseline, AlignmentBaseline, alignmentBaseline, AB_AUTO)
> I'm not sure why expanding these is better... but OK.

Made debugging a snap now. 

Nikolas Zimmermann suggested I make this change in:

https://bugs.webkit.org/show_bug.cgi?id=43254

[Nikolas Zimmermann]

(In reply to comment #10)
> (From update of attachment 63076 [details])
> WebCore/ChangeLog:1
>  +  2010-07-30  [e-mail]  <[e-mail]>
> This should be your Full Name <email>, no email twice. :)
> 
> WebCore/rendering/style/SVGRenderStyle.h: 
>  +      SVG_RS_DEFINE_ATTRIBUTE(EAlignmentBaseline, AlignmentBaseline, alignmentBaseline, AB_AUTO)
> I'm not sure why expanding these is better... but OK.

It was your request, a long time ago, you even added the FIXME :-)