Bug 43251 – Web Inspector: add support for DOM-style events to WebInspector Extensions API

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

The extension API should support DOM-style events in addition to current Chrome-style event sinks, e.g.

webInspector.resources.addEventListener("finish", eventHandler, false) as a counterpart for webInspector.resources.onFinished.addListener(callback).
The eventHandler function should be passed a DOM Event object with properties specific to the event type.

[Andrey Kosyakov]

Created attachment 63605 [details]
patch

More tests for different event types are coming.

[Pavel Feldman]

Timothy, do you want to review this?

[Joseph Pecoraro]

Comment on attachment 63605 [details]
patch

> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog

> +++ b/LayoutTests/ChangeLog
> +        Web Inspector: added tests for event handling, updated expectations to include new API methods.
> +        https://bugs.webkit.org/show_bug.cgi?id=43344

I just glanced at this and felt I should not a couple things:

  1) wrong bug number! The bug # for this was 43251
  2) ChangeLogs have a typical format which tools like
     webkit-patch and prepare-ChangeLog will generate
     for you. Don't edit the bug title & link. If you have
     comments, put them beneath the bug link.

Glancing at some of your other commits, it looks like you've
been replacing the bug title with your comments. Not a big
deal, just something I noticed.

Examples of good style (on the front page of trac.webkit.org):
http://trac.webkit.org/changeset/64855
http://trac.webkit.org/changeset/64852

[Pavel Feldman]

Comment on attachment 63605 [details]
patch

Pending review for too long. Feel free to re-submit.