Bug 43251 - Web Inspector: add support for DOM-style events to WebInspector Extensions API
Summary: Web Inspector: add support for DOM-style events to WebInspector Extensions API
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-07-30 08:00 PDT by Andrey Kosyakov
Modified: 2014-12-11 17:13 PST (History)
8 users (show)

See Also:

patch (16.27 KB, patch)
2010-08-05 10:23 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2010-07-30 08:00:44 PDT
The extension API should support DOM-style events in addition to current Chrome-style event sinks, e.g.

webInspector.resources.addEventListener("finish", eventHandler, false) as a counterpart for webInspector.resources.onFinished.addListener(callback).
The eventHandler function should be passed a DOM Event object with properties specific to the event type.
Comment 1 Andrey Kosyakov 2010-08-05 10:23:46 PDT
Created attachment 63605 [details]

More tests for different event types are coming.
Comment 2 Pavel Feldman 2010-08-06 01:31:17 PDT
Timothy, do you want to review this?
Comment 3 Joseph Pecoraro 2010-08-06 09:57:34 PDT
Comment on attachment 63605 [details]

> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog

> +++ b/LayoutTests/ChangeLog
> +        Web Inspector: added tests for event handling, updated expectations to include new API methods.
> +        https://bugs.webkit.org/show_bug.cgi?id=43344

I just glanced at this and felt I should not a couple things:

  1) wrong bug number! The bug # for this was 43251
  2) ChangeLogs have a typical format which tools like
     webkit-patch and prepare-ChangeLog will generate
     for you. Don't edit the bug title & link. If you have
     comments, put them beneath the bug link.

Glancing at some of your other commits, it looks like you've
been replacing the bug title with your comments. Not a big
deal, just something I noticed.

Examples of good style (on the front page of trac.webkit.org):
Comment 4 Pavel Feldman 2010-12-30 05:10:03 PST
Comment on attachment 63605 [details]

Pending review for too long. Feel free to re-submit.