RESOLVED FIXED43250
[IndexedDB] IndexedDatabaseRequest should be called IndexedDatabase 
https://bugs.webkit.org/show_bug.cgi?id=43250
Summary [IndexedDB] IndexedDatabaseRequest should be called IndexedDatabase
Andrei Popescu
Reported 2010-07-30 07:48:24 PDT
[IndexedDB] IndexedDatabaseRequest should be called IndexedDatabase
Attachments
Patch (59.70 KB, patch)
2010-07-30 09:18 PDT, Andrei Popescu 		jorlow: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrei Popescu
Comment 1 2010-07-30 09:18:06 PDT
Created attachment 63066 [details] Patch
Jeremy Orlow
Comment 2 2010-07-30 10:38:11 PDT
Comment on attachment 63066 [details] Patch WebCore/CMakeLists.txt:1436 + storage/IDBDatabaseBackend.cpp Wrong! WebCore/WebCore.vcproj/WebCore.vcproj:50120 + RelativePath="..\storage\IDBDatabaseBackendImpl.h" These go first WebKit/chromium/src/WebIDBDatabaseImpl.h:43 + WebIDBDatabaseImpl(WTF::PassRefPtr<WebCore::IDBDatabaseBackendInterface> databaseBackend); delete variable name WebCore/storage/IDBRequest.cpp:76 + void IDBRequest::onSuccess(PassRefPtr<IDBDatabaseBackendInterface> idbDatabaseBackend) I think I used some different naming when I did it. Maybe double check in here and the IDBCallback files that we're consistent. It's fine to do that in the next renaming patch too. WebCore/storage/IDBFactoryBackendImpl.cpp:57 + RefPtr<IDBDatabaseBackendInterface> databaseBackend; I don't think Backend is needed here, but I don't really care. r=me
Andrei Popescu
Comment 3 2010-08-03 03:44:24 PDT
Committed r64543: <http://trac.webkit.org/changeset/64543>
WebKit Review Bot
Comment 4 2010-08-03 04:52:22 PDT
http://trac.webkit.org/changeset/64543 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/64541 http://trac.webkit.org/changeset/64542 http://trac.webkit.org/changeset/64543
Note You need to log in before you can comment on or make changes to this bug.