Bug 43236 - Optimize SVGResources memory usage
Summary: Optimize SVGResources memory usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 02:43 PDT by Nikolas Zimmermann
Modified: 2010-07-30 04:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (30.42 KB, patch)
2010-07-30 02:48 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Updated patch (30.44 KB, patch)
2010-07-30 02:53 PDT, Nikolas Zimmermann 		krit: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-07-30 02:43:24 PDT 
marker*/clip-path/filter/fill/stroke properties can not be applied to all elements.
We should be able to reduce memory usage of the class, by grouping properties that can be applied to certain element categories like "shapes" / "text content elements" / "graphics elements" / "container elements", as the SVG specification describes.

Clipper & Filter & Masker can be grouped, MarkerStart & MarkerMid & MarkerEnd as well as Fill & Stroke.
Comment 1 Nikolas Zimmermann 2010-07-30 02:48:29 PDT 
Created attachment 63039 [details]
Patch
Comment 2 Nikolas Zimmermann 2010-07-30 02:53:25 PDT 
Created attachment 63041 [details]
Updated patch

Add missing ENABLE(FILTERS) guards.
Comment 3 Dirk Schulze 2010-07-30 04:00:52 PDT 
Comment on attachment 63041 [details]
Updated patch

Talked about some changes on tag to clipper mapping. We don't follow the spec for defs,switch,pattern.
r=me
Comment 4 Nikolas Zimmermann 2010-07-30 04:03:05 PDT 
Thanks, landed in r64345.