Bug 43234 - [QT] build fix for symbian
Summary: [QT] build fix for symbian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Mahesh Kulkarni
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-07-30 01:52 PDT by Mahesh Kulkarni
Modified: 2010-08-24 07:49 PDT (History)
3 users (show)

See Also:


Attachments
patch (1015 bytes, patch)
2010-07-30 01:56 PDT, Mahesh Kulkarni
no flags Details | Formatted Diff | Diff
patch (2.01 KB, patch)
2010-07-30 05:19 PDT, Mahesh Kulkarni
no flags Details | Formatted Diff | Diff
patch (15.10 KB, patch)
2010-08-02 04:31 PDT, Mahesh Kulkarni
no flags Details | Formatted Diff | Diff
patch (2.07 KB, patch)
2010-08-02 04:37 PDT, Mahesh Kulkarni
no flags Details | Formatted Diff | Diff
patch (4.30 KB, patch)
2010-08-03 02:45 PDT, Mahesh Kulkarni
no flags Details | Formatted Diff | Diff
patch (2.11 KB, patch)
2010-08-03 04:01 PDT, Mahesh Kulkarni
hausmann: review+
hausmann: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mahesh Kulkarni 2010-07-30 01:52:50 PDT
Build of qtwebkit on symbian has been broken since 
bugs.webkit.org/show_bug.cgi?id=43009 
http://trac.webkit.org/changeset/64105
Comment 1 Mahesh Kulkarni 2010-07-30 01:56:19 PDT
Created attachment 63037 [details]
patch

Fixed symbian build issue
Comment 2 WebKit Commit Bot 2010-07-30 04:10:25 PDT
Comment on attachment 63037 [details]
patch

Clearing flags on attachment: 63037

Committed r64346: <http://trac.webkit.org/changeset/64346>
Comment 3 WebKit Commit Bot 2010-07-30 04:10:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Mahesh Kulkarni 2010-07-30 05:18:38 PDT
Found one more build issue. Patch coming soon
Comment 5 Mahesh Kulkarni 2010-07-30 05:19:59 PDT
Created attachment 63049 [details]
patch

found one more build issue.
1) parameter passing misplaced 
2) casting error on symbian. Converted to int*
Comment 6 Mahesh Kulkarni 2010-08-02 04:31:57 PDT
Created attachment 63190 [details]
patch

As per comments from Simon on irc, changing static_cast to reinterpret_cast.
Comment 7 WebKit Review Bot 2010-08-02 04:33:00 PDT
Attachment 63190 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:49:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Mahesh Kulkarni 2010-08-02 04:37:35 PDT
Created attachment 63191 [details]
patch

Corrected style issue and removed unintended changes :)
Comment 9 Simon Hausmann 2010-08-02 04:43:31 PDT
Comment on attachment 63191 [details]
patch

r=me
Comment 10 WebKit Commit Bot 2010-08-02 05:21:25 PDT
Comment on attachment 63191 [details]
patch

Clearing flags on attachment: 63191

Committed r64456: <http://trac.webkit.org/changeset/64456>
Comment 11 WebKit Commit Bot 2010-08-02 05:21:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Mahesh Kulkarni 2010-08-03 02:45:32 PDT
Created attachment 63311 [details]
patch

def file updated
Comment 13 Mahesh Kulkarni 2010-08-03 04:01:42 PDT
Created attachment 63315 [details]
patch

Updated patch for def files to mark missing exports as absent.
Comment 14 Simon Hausmann 2010-08-24 07:49:32 PDT
Removing from the 2.1 release blocker, as the 2.1 release branch is not affected by the refactorings.