Bug 43226 - Canvas test 2d.composite.operation.clear failing
Summary: Canvas test 2d.composite.operation.clear failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Matthew Delaney
URL:
Keywords: HTML5
Depends on:
Blocks:
 
Reported: 2010-07-29 18:04 PDT by Matthew Delaney
Modified: 2010-08-27 19:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2010-07-29 18:07 PDT, Matthew Delaney 		no flags Details | Formatted Diff | Diff
Patch (3.65 KB, patch)
2010-07-30 13:45 PDT, Matthew Delaney 		no flags Details | Formatted Diff | Diff
Updated name of test (3.66 KB, patch)
2010-08-11 11:14 PDT, Matthew Delaney 		no flags Details | Formatted Diff | Diff
Patch (3.63 KB, patch)
2010-08-26 18:04 PDT, Matthew Delaney 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2010-07-29 18:04:42 PDT 
The canvas test 2d.composite.operation.clear fails because webkit supports a vendor specific composite op named "clear" that doesn't follow the conventions of the spec - should be named "webkit-clear" per the spec. However, for compatibility reasons, it doesn't currently make sense to drop the op (or drop by renaming it). Thus, I leave the test to remain on the skip list and make a second version of the test called 2d.composite.operation.clear2 that tests for a bogus op to make sure that we ignore unrecognized ops.
Comment 1 Matthew Delaney 2010-07-29 18:07:37 PDT 
Created attachment 63019 [details]
Patch
Comment 2 Adele Peterson 2010-07-30 10:25:26 PDT 
Comment on attachment 63019 [details]
Patch

Can we support "clear" and "webkit-clear"?
Comment 3 Adele Peterson 2010-07-30 11:09:05 PDT 
After understanding this better, that doesn't seem like that good an idea.

(In reply to comment #2)
> (From update of attachment 63019 [details])
> Can we support "clear" and "webkit-clear"?
Comment 4 Matthew Delaney 2010-07-30 13:45:43 PDT 
Created attachment 63099 [details]
Patch
Comment 5 Matthew Delaney 2010-08-11 11:14:51 PDT 
Created attachment 64137 [details]
Updated name of test

Just updated the name of the new test to avoid any confusion as to the nature of the test.
Comment 6 Andreas Kling 2010-08-16 17:53:47 PDT 
FWIW, this LGTM.
Comment 7 Matthew Delaney 2010-08-26 18:04:47 PDT 
Created attachment 65654 [details]
Patch
Comment 8 Oliver Hunt 2010-08-26 18:06:27 PDT 
Comment on attachment 65654 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2010-08-27 19:42:08 PDT 
Comment on attachment 65654 [details]
Patch

Clearing flags on attachment: 65654

Committed r66294: <http://trac.webkit.org/changeset/66294>
Comment 10 WebKit Commit Bot 2010-08-27 19:42:12 PDT 
All reviewed patches have been landed.  Closing bug.